Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Ignore ASDF warning about gwcs-1.0.0 schema #2451

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Sep 12, 2023

Description

This pull request is to ignore ASDF warning about gwcs-1.0.0 schema because gwcs dev and/or asdf-wcs-schemas 0.2.0 triggers the warning because the schema is no longer supported.

See #2446 (comment)

Fixes #2446

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

because gwcs dev and/or asdf-wcs-schemas 0.2.0 triggers the warning because the schema is no longer supported.
@pllim pllim added testing trivial Only needs one approval instead of two no-changelog-entry-needed changelog bot directive 💤 backport-v3.6.x on-merge: backport to v3.6.x labels Sep 12, 2023
@pllim pllim added this to the 3.6.3 milestone Sep 12, 2023
@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Patch coverage is 100.00% of modified lines.

Files Changed Coverage
...daviz/configs/imviz/tests/test_astrowidgets_api.py 100.00%
jdaviz/configs/mosviz/tests/test_parsers.py 100.00%

📢 Thoughts on this report? Let us know!.

@pllim pllim marked this pull request as ready for review September 12, 2023 22:19
@pllim
Copy link
Contributor Author

pllim commented Sep 12, 2023

I don't see the point in reviewing. CI is green and I already discussed this in detail with @braingram . Just gonna merge.

@pllim pllim merged commit cbc70bd into spacetelescope:main Sep 12, 2023
@pllim pllim deleted the fix-gwcs-schema-too-old branch September 12, 2023 22:21
meeseeksmachine pushed a commit to meeseeksmachine/jdaviz that referenced this pull request Sep 12, 2023
pllim added a commit that referenced this pull request Sep 12, 2023
…1-on-v3.6.x

Backport PR #2451 on branch v3.6.x (TST: Ignore ASDF warning about gwcs-1.0.0 schema)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
imviz mosviz no-changelog-entry-needed changelog bot directive testing trivial Only needs one approval instead of two 💤 backport-v3.6.x on-merge: backport to v3.6.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incompatiblity with asdf dev
1 participant