Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API access (hidden) to disable moment map server-side saving #2469

Merged
merged 2 commits into from
Sep 21, 2023

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented Sep 21, 2023

Description

Similar to #2440 (and using the same solution), this pull request allows disabling the support for saving a moment map to a fits file until we change that implementation to save through the browser client-side.

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@kecnry kecnry added cubeviz trivial Only needs one approval instead of two no-changelog-entry-needed changelog bot directive labels Sep 21, 2023
@kecnry kecnry added this to the 3.7 milestone Sep 21, 2023
@kecnry kecnry marked this pull request as ready for review September 21, 2023 12:24
@kecnry kecnry force-pushed the mast-no-moment-map-save branch from 17d28d0 to 5031449 Compare September 21, 2023 12:34
@kecnry kecnry force-pushed the mast-no-moment-map-save branch from 5031449 to 431f10d Compare September 21, 2023 12:47
@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Patch coverage is 87.50% of modified lines.

❗ Current head 431f10d differs from pull request most recent head e58cebf. Consider uploading reports for the commit e58cebf to get more accurate results

Files Changed Coverage
...configs/cubeviz/plugins/moment_maps/moment_maps.py 80.00%
...nfigs/cubeviz/plugins/tests/test_cubeviz_helper.py 100.00%

📢 Thoughts on this report? Let us know!.

Copy link
Contributor

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just nitpick on error message. LGTM otherwise. Thanks!

jdaviz/configs/cubeviz/plugins/moment_maps/moment_maps.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@rosteen rosteen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, thanks.

Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com>
@kecnry kecnry enabled auto-merge (squash) September 21, 2023 13:17
@kecnry kecnry merged commit 33253d6 into spacetelescope:main Sep 21, 2023
12 checks passed
@kecnry kecnry deleted the mast-no-moment-map-save branch September 21, 2023 14:12
bmorris3 pushed a commit to bmorris3/jdaviz that referenced this pull request Sep 22, 2023
@kecnry kecnry mentioned this pull request Oct 24, 2023
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cubeviz no-changelog-entry-needed changelog bot directive trivial Only needs one approval instead of two
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants