Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

always show viewer-level options regardless of selected layer #2557

Merged

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented Nov 9, 2023

Description

#2543 re-ordered entries in the plot options so that viewer-level options occur before the layer dropdown. This is confusing when the visibilities of some of these entries depend on the selected layer. This PR makes it so that the visibility of these viewer-level options is only based on the selected viewer(s) and not layer(s).

For example, in Imviz with multiselect enabled and NO layer selected, colormap was not showing at all before this PR, but now shows regardless of the selected layer(s).

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@kecnry kecnry added this to the 3.8 milestone Nov 9, 2023
@kecnry kecnry added UI/UX😍 trivial Only needs one approval instead of two labels Nov 9, 2023
@kecnry kecnry force-pushed the plot-options-always-show-viewer-options branch from 916d307 to 4fed345 Compare November 9, 2023 17:06
@kecnry kecnry marked this pull request as ready for review November 9, 2023 17:06
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
...nfigs/default/plugins/plot_options/plot_options.py 91.20% <100.00%> (-0.03%) ⬇️
jdaviz/core/template_mixin.py 91.65% <100.00%> (+0.01%) ⬆️

📢 Thoughts on this report? Let us know!

Copy link
Collaborator

@rosteen rosteen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work, thanks.

@kecnry kecnry merged commit f444c87 into spacetelescope:main Nov 9, 2023
15 checks passed
@kecnry kecnry deleted the plot-options-always-show-viewer-options branch November 9, 2023 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
trivial Only needs one approval instead of two UI/UX😍
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants