Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

always show viewer-level options regardless of selected layer #2557

Merged
merged 1 commit into from
Nov 9, 2023
Merged

always show viewer-level options regardless of selected layer #2557

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGES.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ New Features

- Colorbar now shown on top of the histogram in Plot Options for image viewers. [#2517]

- Reorder viewer and layer settings in Plot Options. [#2543]
- Reorder viewer and layer settings in Plot Options. [#2543, #2557]

Cubeviz
^^^^^^^
Expand Down
6 changes: 3 additions & 3 deletions jdaviz/configs/default/plugins/plot_options/plot_options.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
:hint="multiselect ? 'Select viewers to set options simultaneously' : 'Select the viewer to set options.'"
/>

<div v-if="image_visible_sync.in_subscribed_states && image_visible_value">
<div v-if="image_color_mode_sync.in_subscribed_states">
<glue-state-sync-wrapper :sync="image_color_mode_sync" :multiselect="multiselect" @unmix-state="unmix_state('image_color_mode')">
<v-select
attach
Expand All @@ -69,14 +69,14 @@
</div>

<!-- GENERAL:AXES -->
<glue-state-sync-wrapper v-if="config !== 'imviz'":sync="axes_visible_sync" :multiselect="multiselect" @unmix-state="unmix_state('axes_visible')">
<glue-state-sync-wrapper v-if="axes_visible_sync.in_subscribed_states && config !== 'imviz'" :sync="axes_visible_sync" :multiselect="multiselect" @unmix-state="unmix_state('axes_visible')">
<v-switch
v-model="axes_visible_value"
label="Show Axes"
/>
</glue-state-sync-wrapper>

<glue-state-sync-wrapper v-if="line_visible_value && (!marker_visible_sync.in_subscribed_states || marker_visible_value)" :sync="uncertainty_visible_sync" :multiselect="multiselect" @unmix-state="unmix_state('uncertainty_visible')">
<glue-state-sync-wrapper v-if="uncertainty_visible_sync.in_subscribed_states" :sync="uncertainty_visible_sync" :multiselect="multiselect" @unmix-state="unmix_state('uncertainty_visible')">
<v-switch
v-model="uncertainty_visible_value"
label="Plot uncertainties"
Expand Down