Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open data menu on new blank viewer #2742

Merged
merged 2 commits into from
Mar 29, 2024

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented Mar 7, 2024

Description

This pull request opens the data menu by default for a new, blank, viewer.

Screen.Recording.2024-03-07.at.4.43.22.PM.mov

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@kecnry kecnry added UI/UX😍 trivial Only needs one approval instead of two no-changelog-entry-needed changelog bot directive labels Mar 7, 2024
@kecnry kecnry added this to the 3.9 milestone Mar 7, 2024
@kecnry kecnry marked this pull request as ready for review March 7, 2024 21:44
@kecnry kecnry marked this pull request as draft March 7, 2024 21:46
@kecnry
Copy link
Member Author

kecnry commented Mar 7, 2024

(putting in draft while I work to see if there is a way to have this handled nicely when data is programmatically added immediately after creation 🤔 )

Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.92%. Comparing base (af8d1b8) to head (e4a0d2a).
Report is 50 commits behind head on main.

❗ Current head e4a0d2a differs from pull request most recent head 0471143. Consider uploading reports for the commit 0471143 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2742      +/-   ##
==========================================
+ Coverage   88.85%   88.92%   +0.07%     
==========================================
  Files         108      108              
  Lines       15920    16003      +83     
==========================================
+ Hits        14145    14230      +85     
+ Misses       1775     1773       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kecnry kecnry removed the trivial Only needs one approval instead of two label Mar 8, 2024
kecnry added a commit to kecnry/lcviz that referenced this pull request Mar 8, 2024
if spacetelescope/jdaviz#2742 is merged, we should include this to avoid opening the data menu when creating populated phase viewers
@kecnry kecnry marked this pull request as ready for review March 8, 2024 16:27
kecnry added a commit to kecnry/lcviz that referenced this pull request Mar 11, 2024
if spacetelescope/jdaviz#2742 is merged, we should include this to avoid opening the data menu when creating populated phase viewers
kecnry added a commit to kecnry/lcviz that referenced this pull request Mar 28, 2024
if spacetelescope/jdaviz#2742 is merged, we should include this to avoid opening the data menu when creating populated phase viewers
Copy link
Contributor

@cshanahan1 cshanahan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@javerbukh javerbukh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@kecnry kecnry merged commit adcf76d into spacetelescope:main Mar 29, 2024
18 checks passed
@kecnry kecnry deleted the blank-viewer-data-menu-open branch March 29, 2024 18:22
kecnry added a commit to kecnry/lcviz that referenced this pull request Mar 29, 2024
if spacetelescope/jdaviz#2742 is merged, we should include this to avoid opening the data menu when creating populated phase viewers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants