-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open data menu on new blank viewer #2742
Open data menu on new blank viewer #2742
Conversation
(putting in draft while I work to see if there is a way to have this handled nicely when data is programmatically added immediately after creation 🤔 ) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2742 +/- ##
==========================================
+ Coverage 88.85% 88.92% +0.07%
==========================================
Files 108 108
Lines 15920 16003 +83
==========================================
+ Hits 14145 14230 +85
+ Misses 1775 1773 -2 ☔ View full report in Codecov by Sentry. |
if spacetelescope/jdaviz#2742 is merged, we should include this to avoid opening the data menu when creating populated phase viewers
if spacetelescope/jdaviz#2742 is merged, we should include this to avoid opening the data menu when creating populated phase viewers
if spacetelescope/jdaviz#2742 is merged, we should include this to avoid opening the data menu when creating populated phase viewers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
if spacetelescope/jdaviz#2742 is merged, we should include this to avoid opening the data menu when creating populated phase viewers
Description
This pull request opens the data menu by default for a new, blank, viewer.
Screen.Recording.2024-03-07.at.4.43.22.PM.mov
Change log entry
CHANGES.rst
? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rst
before merge. If no, maintainershould add a
no-changelog-entry-needed
label.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.