-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jdaviz 3.9 updates #68
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #68 +/- ##
==========================================
+ Coverage 93.92% 94.50% +0.57%
==========================================
Files 37 37
Lines 1598 1582 -16
==========================================
- Hits 1501 1495 -6
+ Misses 97 87 -10 ☔ View full report in Codecov by Sentry. |
(but leave infrastructure in place for now)
if spacetelescope/jdaviz#2742 is merged, we should include this to avoid opening the data menu when creating populated phase viewers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go when tests pass.
This PR encompasses minor updates for when we want to update the min-pin on jdaviz to 3.9
Waiting for:
jdaviz 3.9Will also get from upstream:
TODO: