Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jdaviz 3.9 updates #68

Merged
merged 14 commits into from
Apr 5, 2024
Merged

jdaviz 3.9 updates #68

merged 14 commits into from
Apr 5, 2024

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented Dec 1, 2023

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.50%. Comparing base (7b78df5) to head (b6586be).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #68      +/-   ##
==========================================
+ Coverage   93.92%   94.50%   +0.57%     
==========================================
  Files          37       37              
  Lines        1598     1582      -16     
==========================================
- Hits         1501     1495       -6     
+ Misses         97       87      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

(but leave infrastructure in place for now)
if spacetelescope/jdaviz#2742 is merged, we should include this to avoid opening the data menu when creating populated phase viewers
pyproject.toml Outdated Show resolved Hide resolved
@kecnry kecnry removed the waiting-on-jdaviz-release PR requires a release from jdaviz before updating the pin label Apr 5, 2024
@kecnry kecnry marked this pull request as ready for review April 5, 2024 18:31
Copy link
Contributor

@bmorris3 bmorris3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go when tests pass.

@kecnry kecnry merged commit f3edb89 into spacetelescope:main Apr 5, 2024
11 checks passed
@kecnry kecnry deleted the 3.9-updates branch April 5, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants