#699.1 Migrate to monorepo #703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for taxi-dev-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
SnowSuno
commented
Jan 17, 2024
| @@ -23,7 +23,7 @@ const Event2023FallStore = () => { | |||
| itemListToken, | |||
| ])[1] || { items: [] }; | |||
| const getItemFilteredList = useCallback( | |||
| (types) => | |||
| (types: number[]) => | |||
There was a problem hiding this comment.
react의 resolution을 변경하면서 이전에는 오류가 나지 않던 줄에 대한 간단한 fix 입니다
14KGun
approved these changes
Jan 18, 2024
Comment on lines
+41
to
+65
|
|
||
| ## Development | ||
|
|
||
| Run scoped scripts | ||
|
|
||
| ```bash | ||
| pnpm <scope> <script> | ||
| ``` | ||
|
|
||
| Valid scopes are: | ||
| - `web`: Corresponds to `@taxi/web` | ||
| - ~~`app`: (intended) Corresponds to `@taxi/app`~~ | ||
| - ~~`core`: (intended) Corresponds to `@taxi/core`~~ | ||
|
|
||
| ### Examples | ||
|
|
||
| Run `web` development server | ||
| ```bash | ||
| pnpm web start | ||
| ``` | ||
|
|
||
| Install new dependency to `app` | ||
| ```bash | ||
| pnpm app install <package_name> | ||
| ``` |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It closes #699
#700 에서 미처 모두 해결되지 않은 자잘한 이슈들을 해결합니다