Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#699.1 Migrate to monorepo #703

Merged
merged 5 commits into from
Jan 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .prettierignore
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
node_modules
build
.github
tsconfig.build.json
tsconfig.json
26 changes: 26 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,32 @@ $ pnpm install
See [notion page](https://www.notion.so/sparcs/Environment-Variables-1b404bd385fa495bac6d5517b57d72bf).
Refer to [.env.example](.env.example) and write your own `.env`.


## Development

Run scoped scripts

```bash
pnpm <scope> <script>
```

Valid scopes are:
- `web`: Corresponds to `@taxi/web`
- ~~`app`: (intended) Corresponds to `@taxi/app`~~
- ~~`core`: (intended) Corresponds to `@taxi/core`~~

### Examples

Run `web` development server
```bash
pnpm web start
```

Install new dependency to `app`
```bash
pnpm app install <package_name>
```
Comment on lines +41 to +65
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️


## Testing

This project contains E2E tests with Cypress. To run the test, start React development server with `npm start` and run test script by `npm run test` on another shell.
Expand Down
7 changes: 2 additions & 5 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@
"scripts": {
"preinstall": "npx only-allow pnpm",
"web": "pnpm -F @taxi/web",
"build": "pnpm -r build",
"build:all": "pnpm -r build",
"build:web": "pnpm --filter @taxi/web... build",
"test": "pnpm -r test",
"typecheck": "pnpm -r typecheck"
},
Expand All @@ -23,9 +24,5 @@
"eslint-plugin-react-hooks": "^4.2.0",
"eslint-plugin-storybook": "^0.6.15",
"typescript": "^5.1.6"
},
"resolutions": {
"@types/react": "^17.0.2",
"react-error-overlay": "6.0.9"
}
}
2 changes: 1 addition & 1 deletion packages/web/src/pages/Event/Event2023FallStore/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ const Event2023FallStore = () => {
itemListToken,
])[1] || { items: [] };
const getItemFilteredList = useCallback(
(types) =>
(types: number[]) =>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reactresolution을 변경하면서 이전에는 오류가 나지 않던 줄에 대한 간단한 fix 입니다

items.filter(
(item: EventItem) => types.includes(item.itemType) && !item.isDisabled
),
Expand Down
4 changes: 2 additions & 2 deletions packages/web/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@
"vite.config.ts"
],
"compilerOptions": {
"baseUrl": "./src",
"paths": {
"@/*": ["packages/web/src/*"],
"@taxi/*": ["packages/*/src"]
"@/*": ["./*"],
}
}
}
1 change: 1 addition & 0 deletions packages/web/vite.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import svgr from "vite-plugin-svgr";

export default defineConfig({
plugins: [svgr(), react({ jsxImportSource: "@emotion/react" })],
envDir: "../..",
envPrefix: "REACT_APP_",
resolve: {
alias: {
Expand Down
Loading
Loading