[BGD-4953] increase nginx body size limit #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when uploading files from JupyterLab, the chunks sometimes are bigger than the expected 1MB. This increase the limit to 2MB, it should be enough. Same change will be done in CP ingress
epignot
changed the title
ImpSy
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket
https://spotinst.atlassian.net/browse/BGD-4953
Demo
This is recording of a 7.4MB file upload to my workspace.
workspace is running on my cluster
manu-dev-3on which I patch the bigdata-proxy ingress conf adding:Screen.Recording.2024-03-26.at.18.16.24.mov
Ingress conf :
CP ingress was running with charts from this PR : spotinst/bigdata-internal-charts#392
Why
When uploading files from JupyterLab, the chunks sometimes are bigger than the expected 1MB.
Nginx returns
a 413 Payload too largein those casesWhat
This increase the limit to 2MB, it should be enough. Same change will be done in CP ingress