Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dont use websocket protocol for jeg backward compatibility and fix ke… #11

Merged
merged 2 commits into from
Jan 11, 2024
Merged

dont use websocket protocol for jeg backward compatibility and fix ke… #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dbbec42
dont use websocket protocol for jeg backward compatibility and fix ke…
sigmarkarl Jan 10, 2024
14c5dc6
typo for ten minute timeout after wait interval was changed from 1 to…
sigmarkarl Jan 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions packages/running/src/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,13 +192,13 @@ function Item(props: {
) : (
<caretDownIcon.react tag="span" stylesheet="runningItem" />
))}
{typeof icon === 'string' ? (
icon ? (
{icon ? (
typeof icon === 'string' ? (
<img src={icon} />
) : undefined
) : (
<icon.react tag="span" stylesheet="runningItem" />
)}
) : (
<icon.react tag="span" stylesheet="runningItem"/>
)
) : undefined}
<span
className={ITEM_LABEL_CLASS}
title={title}
Expand Down
2 changes: 1 addition & 1 deletion packages/services/src/kernel/default.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1233,7 +1233,7 @@ export class KernelConnection implements Kernel.IKernelConnection {
/**
* Create the kernel websocket connection and add socket status handlers.
*/
private _createSocket = (useProtocols = true) => {
private _createSocket = (useProtocols = false) => {
this._errorIfDisposed();

// Make sure the socket is clear
Expand Down
2 changes: 1 addition & 1 deletion packages/services/src/session/restapi.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ export async function startSession(
};
let data = {"id": "", "execution_state": "waiting"};
let count = 0
while (count++ < 600) {
while (count++ < 300) {
const response = await ServerConnection.makeRequest(url, init, settings);
if (response.status !== 201) {
throw await ServerConnection.ResponseError.create(response);
Expand Down
Loading