dont use websocket protocol for jeg backward compatibility and fix ke… #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rnel view for non existing icons
arnthor-agustsson
approved these changes
Jan 11, 2024
sigmarkarl
deleted the
BGD-4393-fix-websocket-protocol-for-jeg-backward-compat
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dont use websocket protocol for jeg backward compatibility
Jira ticket
https://spotinst.atlassian.net/browse/BGD-4393
Checklist
simple-changeset addcommandWhy
The enterprise gateway doesn't support the new v1 websocket kernel protocol. Default to no protocol until we have an updated version of JEG. FIx the kernel view for non existing icons
What
Return undefined for non existing icons and use no protocol by default in kernel websocket connections
How to test
A kernel entry should appear in the kernel list UI for remote kernels like in jupyterlab 3