Create ViewDistributionBuilder #117
Conversation
Example/ParalayoutSnapshotTests/ViewDistributionSnapshotTests.swift
Outdated
Show resolved
Hide resolved
| public static func buildExpression(_ component: CGFloat) -> [ViewDistributionSpecifying] { | ||
| return [ViewDistributionItem.fixed(component)] | ||
| } | ||
| public static func buildExpression(_ component: Double) -> [ViewDistributionSpecifying] { | ||
| return [ViewDistributionItem.fixed(component)] | ||
| } | ||
| public static func buildExpression(_ component: Int) -> [ViewDistributionSpecifying] { | ||
| return [ViewDistributionItem.fixed(CGFloat(component))] | ||
| } |
There was a problem hiding this comment.
These three methods enable treating raw numbers as fixed positions in the build expression. So instead of 8.fixed you could just write 8.
Happy to delete these for explicit parity with existing APIs. Also happy to add this functionality to existing APIs if folk would like.
There was a problem hiding this comment.
🤔 I agree if we support unspecified numbers they should be fixed, but I think it would be better to keep it explicit. I could see it being very confusing to open a file and see
applyVerticalSubviewDistribution {
oneView
1
twoView
}Not having this context, I'd probably assume that's a flexible spacer. For now I think probably best to keep it explicit.
| public static func buildExpression(_ component: CGFloat) -> [ViewDistributionSpecifying] { | ||
| return [ViewDistributionItem.fixed(component)] | ||
| } | ||
| public static func buildExpression(_ component: Double) -> [ViewDistributionSpecifying] { | ||
| return [ViewDistributionItem.fixed(component)] | ||
| } | ||
| public static func buildExpression(_ component: Int) -> [ViewDistributionSpecifying] { | ||
| return [ViewDistributionItem.fixed(CGFloat(component))] | ||
| } |
There was a problem hiding this comment.
🤔 I agree if we support unspecified numbers they should be fixed, but I think it would be better to keep it explicit. I could see it being very confusing to open a file and see
applyVerticalSubviewDistribution {
oneView
1
twoView
}Not having this context, I'd probably assume that's a flexible spacer. For now I think probably best to keep it explicit.
dfed
force-pushed
the
dfed--view-distribution-builder
branch
from
c5ba8b5
to
143dafe
Compare
|
@NickEntin wrote result builder tests you might enjoy, and removed more of the duplicative tests. Ready for a proper review (and CI run)! |
Resolves #116