Strict concurrency and project maintenance #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
NickEntin
commented
Aug 28, 2024
•
NickEntin
commented
- Support strict concurrency
- Update CI builds to run on macOS 14
- Update snapshot tests to run on iOS 17 and iPadOS 17
- Bump minimum deployment target to iOS 13
* Support strict conncurrency * Update CI builds to run on macOS 14 * Update snapshot tests to run on iOS 17 and iPadOS 17 * Bump minimum deployment target to iOS 13
NickEntin
commented
Aug 29, 2024
| @@ -156,9 +156,9 @@ The extra space within a label above the "cap height" and below the "baseline" o | |||
|
|
|||
| ## Requirements | |||
|
|
|||
| * iOS 12.0 or later | |||
There was a problem hiding this comment.
Apple no longer supports shipping to iOS 12, so there's no point in supporting it here
NickEntin
commented
Aug 29, 2024
| strategy: | ||
| matrix: | ||
| platform: ['iOS_14', 'iOS_13'] |
There was a problem hiding this comment.
In practice I've never seen a difference across iOS versions with Paralayout's test suite, so not too concerned about having more limited iOS version coverage. I think the advantage of having 2x and 3x scales here outweighs the version matrix.
dfed
approved these changes
Aug 29, 2024
| @@ -170,11 +170,13 @@ extension AlignmentContext { | |||
|
|
|||
| // MARK: - | |||
|
|
|||
| @MainActor | |||
| private let ParalayoutLog = OSLog(subsystem: "com.squareup.Paralayout", category: "layout") | |||
There was a problem hiding this comment.
somewhat nuts that OSLog is not Sendable. Maybe that'll change in Xcode 16?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.