-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates for SR2024 #62
Conversation
This avoids them being squashed to the right side
We could, but I specifically wanted to test these changes all together. I've reviewed and approved those separately, so I think it's ok to have them merged as part of this. |
dec98d4
to
e3421aa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this works as a minimum. I might find some time to give this project a bit of TLC before the competition.
- This is run in CI under the same Makefile command as ruff format
- Bulma 1.0.0 has dark theme support, which appears to be good enough for this project
Various dependency updates and formatting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes seem fine. I've only looked at the first set of changes from @RealOrangeOne and haven't re-reviewed the content from #63. Also haven't actually run this locally -- this review is from code inspection alone.
This now raises an error, where it didn't before
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is good for a first pass. Let's merge and deploy this and if we make any other improvements we can consider those individually.
I had a go at implementing markdown / rich text earlier but ran out of time. I remember we really wished we had bullet points and quote last year.
Closes #59
Closes #61
Fixes #40
Includes #50 and #51
Changes are currently deployed and seem to be working.