Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for SR2024 #62

Merged
merged 21 commits into from
Apr 7, 2024
Merged

Updates for SR2024 #62

merged 21 commits into from
Apr 7, 2024

Conversation

RealOrangeOne
Copy link
Member

@RealOrangeOne RealOrangeOne commented Mar 30, 2024

Closes #59
Closes #61
Fixes #40
Includes #50 and #51

Changes are currently deployed and seem to be working.

@RealOrangeOne RealOrangeOne marked this pull request as ready for review April 4, 2024 21:53
@PeterJCLaw
Copy link
Member

Includes #50 and #51

Suggest we get those separately merged first?

@RealOrangeOne
Copy link
Member Author

We could, but I specifically wanted to test these changes all together. I've reviewed and approved those separately, so I think it's ok to have them merged as part of this.

@RealOrangeOne RealOrangeOne force-pushed the sr2024 branch 2 times, most recently from dec98d4 to e3421aa Compare April 4, 2024 22:17
Copy link
Contributor

@trickeydan trickeydan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this works as a minimum. I might find some time to give this project a bit of TLC before the competition.

trickeydan and others added 7 commits April 5, 2024 17:49
- This is run in CI under the same Makefile command as ruff format
- Bulma 1.0.0 has dark theme support, which appears to be good enough for this project
Various dependency updates and formatting
requirements-dev.txt Outdated Show resolved Hide resolved
Copy link
Member

@PeterJCLaw PeterJCLaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes seem fine. I've only looked at the first set of changes from @RealOrangeOne and haven't re-reviewed the content from #63. Also haven't actually run this locally -- this review is from code inspection alone.

This now raises an error, where it didn't before
@RealOrangeOne RealOrangeOne requested a review from trickeydan April 7, 2024 12:44
Copy link
Contributor

@trickeydan trickeydan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good for a first pass. Let's merge and deploy this and if we make any other improvements we can consider those individually.

I had a go at implementing markdown / rich text earlier but ran out of time. I remember we really wished we had bullet points and quote last year.

@raccube raccube merged commit 9523420 into main Apr 7, 2024
6 checks passed
@raccube raccube deleted the sr2024 branch April 7, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dark theme
4 participants