-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow arbitrary python code #493
Conversation
Tests green:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM otherwise
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
The decision is not public, can you summarize what this is about and if it is something that is documented please include a link to the docs. If it's not documented can you briefly summarize why note? Does this need to be mentioned in the release notes? |
This is to allow the user to add arbitrary python code to the We've got it documented in our superset docs and airflow docs However, this can be used for any case where superset allows us to replace functions with custom ones. It was driven by superset documentation about custom OIDC manager and we found that we should add it to airflow too. We've reached a decision on that this is how airflow wants to be configured ( no matter how ugly it might appear ) and thus we want the operator to be useful in this case. We've had an customer for airflow who wrote their whole config for themself ( basically ignoring the operators work and thus it's not used ) to achieve having own classes and functions. They now can use the configs the operator provides and have their custom code as a config. I can't really make a objective statement weather or not we should mention it in the release notes. For me it should as it enables some customers and they might wanna know. Left to do: Do we want to add python libraries to the |
Thank you. In that case: Can you please add a short sentence as it could appear in the release notes as a comment here? |
Sure. Release Notes: |
Description
This PR is the outcome of the decision https://github.com/stackabletech/decisions/issues/21
Contains:
Definition of Done Checklist
Author
Reviewer
Acceptance