Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow arbitrary python code #493

Merged
merged 8 commits into from
Aug 27, 2024
Merged

Conversation

Maleware
Copy link
Contributor

Description

This PR is the outcome of the decision https://github.com/stackabletech/decisions/issues/21

Contains:

  • CONFIG_OVERRIDE_FILE_HEADER_KEY (operator-rs constant)
  • CONFIG_OVERRIDE_FILE_FOOTER_KEY (operator-rs constant)
  • Bump stackable-operator from 0.73.0 to 0.74.0
  • Adding Error for writeln!

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Preview Give feedback

Reviewer

Preview Give feedback

Acceptance

Preview Give feedback

@Maleware Maleware self-assigned this Aug 23, 2024
@Maleware Maleware changed the title Feature/allow arbitrary python code Allow arbitrary python code Aug 23, 2024
@Maleware
Copy link
Contributor Author

Tests green:
🟢

--- PASS: kuttl (206.16s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/smoke_airflow-2.9.2_openshift-false_executor-celery (206.12s)
PASS

Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

CHANGELOG.md Outdated Show resolved Hide resolved
rust/operator-binary/src/airflow_controller.rs Outdated Show resolved Hide resolved
Maleware and others added 2 commits August 27, 2024 09:01
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Maleware Maleware added this pull request to the merge queue Aug 27, 2024
Merged via the queue into main with commit e8cdf10 Aug 27, 2024
31 checks passed
@Maleware Maleware deleted the feature/allow-arbitrary-python-code branch August 27, 2024 07:33
@lfrancke
Copy link
Member

lfrancke commented Sep 2, 2024

The decision is not public, can you summarize what this is about and if it is something that is documented please include a link to the docs. If it's not documented can you briefly summarize why note?

Does this need to be mentioned in the release notes?

@Maleware
Copy link
Contributor Author

Maleware commented Sep 2, 2024

This is to allow the user to add arbitrary python code to the webserver_config.py.

We've got it documented in our superset docs and airflow docs

However, this can be used for any case where superset allows us to replace functions with custom ones. It was driven by superset documentation about custom OIDC manager and we found that we should add it to airflow too.

We've reached a decision on that this is how airflow wants to be configured ( no matter how ugly it might appear ) and thus we want the operator to be useful in this case.

We've had an customer for airflow who wrote their whole config for themself ( basically ignoring the operators work and thus it's not used ) to achieve having own classes and functions. They now can use the configs the operator provides and have their custom code as a config.

I can't really make a objective statement weather or not we should mention it in the release notes. For me it should as it enables some customers and they might wanna know.

Left to do: Do we want to add python libraries to the Airflow Dockerfile to have OIDC supported properly, if a customer chooses to do so?

@lfrancke
Copy link
Member

Thank you. In that case: Can you please add a short sentence as it could appear in the release notes as a comment here?

@Maleware
Copy link
Contributor Author

Sure.

Release Notes:
Apache Airflow: Allow custom arbitrary python code in webserver_config.py

@lfrancke lfrancke added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Sep 13, 2024
@Maleware Maleware mentioned this pull request Oct 9, 2024
3 tasks
@Maleware Maleware mentioned this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release/2024-11 release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants