Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump operator-rs to 0.62.0 #454

Merged
merged 35 commits into from
Feb 5, 2024
Merged

chore: bump operator-rs to 0.62.0 #454

merged 35 commits into from
Feb 5, 2024

Conversation

NickLarsenNZ
Copy link
Member

@NickLarsenNZ NickLarsenNZ commented Jan 11, 2024 •
edited
Loading

Description

  • BREAKING Removed legacy node selector on roleGroups.
  • Bump operator-rs to 0.62.0 and Rust toolchain to 1.75.0
  • Use new label builders.
  • Code style changes

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author
Preview Give feedback

Reviewer
Preview Give feedback

Acceptance
Preview Give feedback

@NickLarsenNZ NickLarsenNZ self-assigned this Jan 11, 2024
@NickLarsenNZ NickLarsenNZ mentioned this pull request Jan 11, 2024
Closed
@NickLarsenNZ NickLarsenNZ changed the title chore: bump operator-rs to 0.60.1 chore: bump operator-rs to 0.62.0 Jan 19, 2024
@NickLarsenNZ NickLarsenNZ mentioned this pull request Jan 22, 2024
Merged
@NickLarsenNZ NickLarsenNZ marked this pull request as ready for review January 22, 2024 12:24
@sbernauer
Copy link
Member

Sorry for bringing the bad news but there are some merge conflicts with #457

@NickLarsenNZ
Copy link
Member Author

NickLarsenNZ commented Jan 22, 2024 •
edited
Loading

Sorry for bringing the bad news but there are some merge conflicts with #457

Story of my day @sbernauer... will fix and request approval

@NickLarsenNZ
Copy link
Member Author

Oops, missed this and ended up doing it in parallel.. dunno if there's anything relevant to grab from it but https://gist.github.com/nightkr/da4eb77f001dfb59a85bc43cbff39634

@nightkr maybe in a new PR? I'd like to get this in now so others can build off of it as the merge conflicts are getting tricky to resolve.

@nightkr nightkr self-requested a review January 23, 2024 08:52
nightkr
nightkr reviewed Jan 23, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
rust/crd/src/lib.rs Outdated Show resolved Hide resolved
rust/operator-binary/src/hdfs_controller.rs Outdated Show resolved Hide resolved
rust/operator-binary/src/kerberos.rs Outdated Show resolved Hide resolved
rust/operator-binary/src/kerberos.rs Outdated Show resolved Hide resolved
rust/operator-binary/src/pod_svc_controller.rs Outdated Show resolved Hide resolved
rust/operator-binary/src/pod_svc_controller.rs Outdated Show resolved Hide resolved
@Techassi Techassi mentioned this pull request Jan 23, 2024
Merged
@NickLarsenNZ
update nixpkgs to get rust 1.75
1bcc490 
```
This is version 0.0.0-dev, built for x86_64-unknown-linux-gnu by rustc 1.75.0 (82e1608df 2023-12-21) (built from a source tarball) at Wed, 24 Jan 2024 08:59:02 +0000
```
This was referenced Jan 24, 2024
Merged
Open
Techassi
Techassi approved these changes Feb 2, 2024
View reviewed changes
Copy link
Member

@Techassi Techassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, really like how you cleaned up the errors and the different builders.

rust/operator-binary/src/hdfs_controller.rs Show resolved Hide resolved
rust/operator-binary/src/kerberos.rs Show resolved Hide resolved
@NickLarsenNZ NickLarsenNZ added this pull request to the merge queue Feb 2, 2024
@NickLarsenNZ NickLarsenNZ removed this pull request from the merge queue due to a manual request Feb 2, 2024
@lfrancke lfrancke added release-note/action-required Denotes a PR that introduces potentially breaking changes that require user action. release/2024-03 labels Feb 2, 2024
@NickLarsenNZ
Copy link
Member Author

Merging, even though kuttl tests aren't working yet. We will fix forward.

@NickLarsenNZ NickLarsenNZ added this pull request to the merge queue Feb 5, 2024
Merged via the queue into main with commit b84cc52 Feb 5, 2024
30 checks passed
@NickLarsenNZ NickLarsenNZ deleted the chore/bump-operator-rs-0.60.1 branch February 5, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Techassi Techassi Techassi approved these changes

@nightkr nightkr Awaiting requested review from nightkr

Assignees

@NickLarsenNZ NickLarsenNZ

Labels
release/2024-03 release-note/action-required Denotes a PR that introduces potentially breaking changes that require user action.
Projects
Stackable Engineering
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@NickLarsenNZ @sbernauer @siegfriedweber @nightkr @Techassi @lfrancke