Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Update product-config #682

Merged
merged 4 commits into from
Oct 31, 2023
Merged

refactor: Update product-config #682

merged 4 commits into from
Oct 31, 2023

Conversation

Techassi
Copy link
Member

@Techassi Techassi self-assigned this Oct 31, 2023
@Techassi Techassi mentioned this pull request Oct 31, 2023
Closed
sbernauer
sbernauer previously approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sbernauer
Copy link
Member

A changelog entry would be nice, as this is not a random third-party crate, but a core Stackable library

@Techassi Techassi requested a review from sbernauer October 31, 2023 12:28
@Techassi Techassi enabled auto-merge October 31, 2023 12:29
@Techassi Techassi added this pull request to the merge queue Oct 31, 2023
Merged via the queue into main with commit 82709b5 Oct 31, 2023
16 checks passed
@Techassi Techassi deleted the refactor/product-config-errors branch October 31, 2023 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbernauer sbernauer sbernauer approved these changes

Assignees

@Techassi Techassi

Labels
None yet
Projects
Stackable Engineering
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Techassi @sbernauer