feat: Add support for DynamicValues struct
#723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I will convert the input and output to fixture files in the next commit.
NickLarsenNZ
approved these changes
Jan 25, 2024
Techassi
changed the title
DynamicValues struct
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support to directly work with an abstracted view of a Helm Value file by having an in-memory representation to ease the deployment using dynamic values. This is inspired by DynamicObject.
The implementation makes the assumption, that all our operators use a common set of key/values in their
values.yamlfiles. Currently, we don't use Rust as a source of truth for these definitions. Instead, the values files are maintained manually. I'm experimenting with this in my private time.Reviewers should also make suggestions, if we should add or remove certain keys.
Tasks