Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Serde impl for CpuQuantity and MemoryQuantity #724

Merged
merged 5 commits into from
Jan 23, 2024

Conversation

Techassi
Copy link
Member

This PR adds Serde Deserialize and Serialize support for CpuQuantity and MemoryQuantity.

This change is required for #723.

@Techassi Techassi self-assigned this Jan 23, 2024
@Techassi Techassi marked this pull request as ready for review January 23, 2024 11:32
@NickLarsenNZ NickLarsenNZ self-requested a review January 23, 2024 13:18
NickLarsenNZ
NickLarsenNZ previously approved these changes Jan 23, 2024
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM judging by the test cases

@Techassi
Copy link
Member Author

Fixed a typo, needs approval once again...

@Techassi Techassi requested a review from NickLarsenNZ January 23, 2024 13:24
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Techassi Techassi added this pull request to the merge queue Jan 23, 2024
Merged via the queue into main with commit 6bbf707 Jan 23, 2024
17 checks passed
@Techassi Techassi deleted the feat/quantities-serde-impl branch January 23, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants