-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tests-integration): add binaries for integration test #1265
feat(tests-integration): add binaries for integration test #1265
Conversation
Benchmark movements: |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1265 +/- ##
===========================================
- Coverage 74.18% 28.85% -45.34%
===========================================
Files 359 207 -152
Lines 36240 22225 -14015
Branches 36240 22225 -14015
===========================================
- Hits 26886 6412 -20474
- Misses 7220 15146 +7926
+ Partials 2134 667 -1467
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
fd24b04
to
ac5f4c9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 8 files at r1, all commit messages.
Reviewable status: 1 of 8 files reviewed, 2 unresolved discussions (waiting on @Itay-Tsabary-Starkware)
a discussion (no related file):
Please separate to smaller PRs.
crates/tests-integration/src/integration_test_config_utils.rs
line 27 at r1 (raw file):
// Create config file for the sequencer node. let json_data = json!({ "rpc_state_reader_config.json_rpc_version": config.rpc_state_reader_config.json_rpc_version,
Strings are fragile; can you work with enums, maybe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 8 files reviewed, 2 unresolved discussions (waiting on @Itay-Tsabary-Starkware)
crates/tests-integration/src/integration_test_config_utils.rs
line 27 at r1 (raw file):
Previously, elintul (Elin) wrote…
Strings are fragile; can you work with enums, maybe?
Or anything strongly typed.
ac5f4c9
to
2c30da0
Compare
Benchmark movements: |
47883ef
to
0df28d4
Compare
2c30da0
to
88d6b9f
Compare
commit-id:56c09be1
88d6b9f
to
877b730
Compare
Closing pull request: commit has gone away |
This change is