Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tests-integration): add binaries for integration test #1265

Conversation

Itay-Tsabary-Starkware
Copy link
Contributor

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware commented Oct 8, 2024

This change is Reviewable

Copy link

github-actions bot commented Oct 8, 2024

Benchmark movements:
tree_computation_flow performance regressed!
tree_computation_flow time: [35.064 ms 35.378 ms 35.724 ms]
change: [+1.5151% +2.4661% +3.5659%] (p = 0.00 < 0.05)
Performance has regressed.
Found 19 outliers among 100 measurements (19.00%)
10 (10.00%) high mild
9 (9.00%) high severe

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 28.85%. Comparing base (b0cfe82) to head (ac5f4c9).
Report is 268 commits behind head on main.

Files with missing lines Patch % Lines
crates/mempool_node/src/main.rs 0.00% 3 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (b0cfe82) and HEAD (ac5f4c9). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (b0cfe82) HEAD (ac5f4c9)
3 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1265       +/-   ##
===========================================
- Coverage   74.18%   28.85%   -45.34%     
===========================================
  Files         359      207      -152     
  Lines       36240    22225    -14015     
  Branches    36240    22225    -14015     
===========================================
- Hits        26886     6412    -20474     
- Misses       7220    15146     +7926     
+ Partials     2134      667     -1467     
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware force-pushed the pr/Itay-Tsabary-Starkware/tsabary/integration_test/56c09be1 branch from fd24b04 to ac5f4c9 Compare October 8, 2024 18:03
Copy link
Collaborator

@elintul elintul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 8 files at r1, all commit messages.
Reviewable status: 1 of 8 files reviewed, 2 unresolved discussions (waiting on @Itay-Tsabary-Starkware)

a discussion (no related file):
Please separate to smaller PRs.



crates/tests-integration/src/integration_test_config_utils.rs line 27 at r1 (raw file):

    // Create config file for the sequencer node.
    let json_data = json!({
        "rpc_state_reader_config.json_rpc_version": config.rpc_state_reader_config.json_rpc_version,

Strings are fragile; can you work with enums, maybe?

Copy link
Collaborator

@elintul elintul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 8 files reviewed, 2 unresolved discussions (waiting on @Itay-Tsabary-Starkware)


crates/tests-integration/src/integration_test_config_utils.rs line 27 at r1 (raw file):

Previously, elintul (Elin) wrote…

Strings are fragile; can you work with enums, maybe?

Or anything strongly typed.

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware force-pushed the pr/Itay-Tsabary-Starkware/tsabary/integration_test/56c09be1 branch from ac5f4c9 to 2c30da0 Compare October 9, 2024 19:17
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware changed the base branch from main to pr/Itay-Tsabary-Starkware/tsabary/integration_test/24ddd75d October 9, 2024 19:17
Copy link

github-actions bot commented Oct 9, 2024

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [34.755 ms 34.806 ms 34.858 ms]
change: [-3.8771% -2.6607% -1.5364%] (p = 0.00 < 0.05)
Performance has improved.
Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high mild

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware force-pushed the pr/Itay-Tsabary-Starkware/tsabary/integration_test/24ddd75d branch from 47883ef to 0df28d4 Compare October 9, 2024 19:41
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware force-pushed the pr/Itay-Tsabary-Starkware/tsabary/integration_test/56c09be1 branch from 2c30da0 to 88d6b9f Compare October 9, 2024 19:41
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware force-pushed the pr/Itay-Tsabary-Starkware/tsabary/integration_test/56c09be1 branch from 88d6b9f to 877b730 Compare October 10, 2024 09:47
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware changed the base branch from pr/Itay-Tsabary-Starkware/tsabary/integration_test/24ddd75d to main October 10, 2024 09:47
@Itay-Tsabary-Starkware
Copy link
Contributor Author

Closing pull request: commit has gone away

@github-actions github-actions bot locked and limited conversation to collaborators Oct 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants