-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(mempool_node): fix gateway config to point to chain_id #1285
fix(mempool_node): fix gateway config to point to chain_id #1285
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion
crates/mempool_node/src/config/mod.rs
line 289 at r1 (raw file):
fn default() -> Self { Self { chain_id: DEFAULT_CHAIN_ID,
Doesn't have a default value, I suspect that for a reason, so I didn't want to add one.
This prevents deriving the Default
trait implementation.
Code quote:
chain_id: DEFAULT_CHAIN_ID,
commit-id:24ddd75d
47883ef
to
0df28d4
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1285 +/- ##
==========================================
- Coverage 74.18% 6.94% -67.25%
==========================================
Files 359 177 -182
Lines 36240 17736 -18504
Branches 36240 17736 -18504
==========================================
- Hits 26886 1231 -25655
- Misses 7220 16470 +9250
+ Partials 2134 35 -2099
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Itay-Tsabary-Starkware)
crates/mempool_node/src/config/mod.rs
line 296 at r2 (raw file):
http_server_config: Default::default(), rpc_state_reader_config: Default::default(), compiler_config: Default::default(),
You can replace with , ..Default::default()
Code quote:
components: Default::default(),
batcher_config: Default::default(),
consensus_manager_config: Default::default(),
gateway_config: Default::default(),
http_server_config: Default::default(),
rpc_state_reader_config: Default::default(),
compiler_config: Default::default(),
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions
commit-id:24ddd75d
Stack:
This change is