Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mempool_node): fix gateway config to point to chain_id #1285

Conversation

Itay-Tsabary-Starkware
Copy link
Contributor

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware commented Oct 9, 2024

commit-id:24ddd75d


Stack:

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.


This change is Reviewable

Copy link
Contributor Author

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion


crates/mempool_node/src/config/mod.rs line 289 at r1 (raw file):

    fn default() -> Self {
        Self {
            chain_id: DEFAULT_CHAIN_ID,

Doesn't have a default value, I suspect that for a reason, so I didn't want to add one.
This prevents deriving the Default trait implementation.

Code quote:

chain_id: DEFAULT_CHAIN_ID,

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware force-pushed the pr/Itay-Tsabary-Starkware/tsabary/integration_test/24ddd75d branch from 47883ef to 0df28d4 Compare October 9, 2024 19:41
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 94.73684% with 1 line in your changes missing coverage. Please review.

Project coverage is 6.94%. Comparing base (b0cfe82) to head (0df28d4).
Report is 299 commits behind head on main.

Files with missing lines Patch % Lines
crates/mempool_node/src/config/mod.rs 94.73% 0 Missing and 1 partial ⚠️

❗ There is a different number of reports uploaded between BASE (b0cfe82) and HEAD (0df28d4). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (b0cfe82) HEAD (0df28d4)
3 1
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #1285       +/-   ##
==========================================
- Coverage   74.18%   6.94%   -67.25%     
==========================================
  Files         359     177      -182     
  Lines       36240   17736    -18504     
  Branches    36240   17736    -18504     
==========================================
- Hits        26886    1231    -25655     
- Misses       7220   16470     +9250     
+ Partials     2134      35     -2099     
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@yair-starkware yair-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Itay-Tsabary-Starkware)


crates/mempool_node/src/config/mod.rs line 296 at r2 (raw file):

            http_server_config: Default::default(),
            rpc_state_reader_config: Default::default(),
            compiler_config: Default::default(),

You can replace with , ..Default::default()

Code quote:

            components: Default::default(),
            batcher_config: Default::default(),
            consensus_manager_config: Default::default(),
            gateway_config: Default::default(),
            http_server_config: Default::default(),
            rpc_state_reader_config: Default::default(),
            compiler_config: Default::default(),

Copy link
Contributor Author

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware merged commit 778ab3a into main Oct 10, 2024
12 of 18 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants