Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add macro to derive struct field names #1706

Merged
merged 2 commits into from
Nov 1, 2024

Conversation

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 30.30303% with 23 lines in your changes missing coverage. Please review.

Project coverage is 6.38%. Comparing base (e3165c4) to head (f6d6a4d).
Report is 129 commits behind head on main.

Files with missing lines Patch % Lines
crates/papyrus_proc_macros/src/lib.rs 0.00% 23 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #1706       +/-   ##
==========================================
- Coverage   40.10%   6.38%   -33.73%     
==========================================
  Files          26     263      +237     
  Lines        1895   30319    +28424     
  Branches     1895   30319    +28424     
==========================================
+ Hits          760    1935     +1175     
- Misses       1100   28320    +27220     
- Partials       35      64       +29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@nadin-Starkware nadin-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware force-pushed the spr/main/901f3b1a branch 2 times, most recently from 2a4d3bb to bf3a1ad Compare October 31, 2024 18:05
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware changed the base branch from spr/main/0c02cd67 to main November 1, 2024 06:35
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware merged commit c332d83 into main Nov 1, 2024
19 of 21 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants