chore(sequencer_node): remove chain_id from config

[Itay-Tsabary-Starkware]

Stack:

• chore(sequencer_node): add fee token addresses as required target params #1725
• chore(sequencer_node): remove chain_id from config #1710 ⬅

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

[reviewable-StarkWare]

This change is 

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.65%. Comparing base (e3165c4) to head (6722252).
Report is 154 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #1710       +/-   ##
===========================================
+ Coverage   40.10%   50.65%   +10.54%     
===========================================
  Files          26      286      +260     
  Lines        1895    31912    +30017     
  Branches     1895    31912    +30017     
===========================================
+ Hits          760    16164    +15404     
- Misses       1100    14619    +13519     
- Partials       35     1129     +1094     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[nadin-Starkware]

Reviewable status: 0 of 6 files reviewed, 1 unresolved discussion (waiting on @Itay-Tsabary-Starkware)

---

crates/mempool_node/src/config/node_config.rs line 64 at r2 (raw file):

    /// The [chain id](https://docs.rs/starknet_api/latest/starknet_api/core/struct.ChainId.html) of the Starknet network.
    #[validate(custom = "validate_ascii")]
    pub chain_id: ChainId,

Why not adding the required params as a field here?

[Itay-Tsabary-Starkware]

Reviewable status: 0 of 6 files reviewed, 1 unresolved discussion (waiting on @nadin-Starkware)

---

crates/mempool_node/src/config/node_config.rs line 64 at r2 (raw file):

Previously, nadin-Starkware (Nadin Jbara) wrote…

Why not adding the required params as a field here?

They are implicitly added as pointer params. Let's further discuss f2f.

[github-actions]

Artifacts upload triggered. View details here

[nadin-Starkware]

Reviewed 3 of 6 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)

[Itay-Tsabary-Starkware]

✓ Commit merged in pull request #1725