Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename mempool node #1755

Merged
merged 1 commit into from
Nov 3, 2024
Merged

chore: rename mempool node #1755

merged 1 commit into from
Nov 3, 2024

Conversation

nadin-Starkware
Copy link
Collaborator

@nadin-Starkware nadin-Starkware commented Nov 3, 2024

commit-id:cc9e68a7


Stack:

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

github-actions bot commented Nov 3, 2024

Artifacts upload triggered. View details here

Copy link

codecov bot commented Nov 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.29%. Comparing base (e3165c4) to head (3f5dd71).
Report is 157 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1755       +/-   ##
===========================================
+ Coverage   40.10%   77.29%   +37.19%     
===========================================
  Files          26      366      +340     
  Lines        1895    38623    +36728     
  Branches     1895    38623    +36728     
===========================================
+ Hits          760    29854    +29094     
- Misses       1100     6523     +5423     
- Partials       35     2246     +2211     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Nov 3, 2024

Artifacts upload triggered. View details here

Copy link

github-actions bot commented Nov 3, 2024

Artifacts upload triggered. View details here

commit-id:cc9e68a7
Copy link

github-actions bot commented Nov 3, 2024

Artifacts upload triggered. View details here

Copy link

github-actions bot commented Nov 3, 2024

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [34.811 ms 34.873 ms 34.949 ms]
change: [-3.9366% -2.4183% -1.0729%] (p = 0.00 < 0.05)
Performance has improved.
Found 5 outliers among 100 measurements (5.00%)
3 (3.00%) high mild
2 (2.00%) high severe

Copy link
Contributor

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 21 of 21 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @nadin-Starkware)

@nadin-Starkware nadin-Starkware merged commit 65a9af6 into main Nov 3, 2024
21 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants