Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename mempool infra #1757

Closed
wants to merge 1 commit into from

Conversation

nadin-Starkware
Copy link
Collaborator

@nadin-Starkware nadin-Starkware commented Nov 3, 2024

Stack:

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

github-actions bot commented Nov 3, 2024

Artifacts upload triggered. View details here

Copy link

codecov bot commented Nov 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.30%. Comparing base (d1a224b) to head (f64aa2b).

Additional details and impacted files
@@                  Coverage Diff                   @@
##           spr/main/b25a11a4    #1757       +/-   ##
======================================================
+ Coverage               5.37%   77.30%   +71.92%     
======================================================
  Files                    263      366      +103     
  Lines                  29929    38635     +8706     
  Branches               29929    38635     +8706     
======================================================
+ Hits                    1610    29865    +28255     
+ Misses                 28266     6525    -21741     
- Partials                  53     2245     +2192     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Nov 3, 2024

Artifacts upload triggered. View details here

Copy link

github-actions bot commented Nov 3, 2024

Artifacts upload triggered. View details here

Copy link

github-actions bot commented Nov 3, 2024

Artifacts upload triggered. View details here

Copy link

github-actions bot commented Nov 3, 2024

Artifacts upload triggered. View details here

Copy link
Contributor

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 22 of 22 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @nadin-Starkware)

Copy link

github-actions bot commented Nov 3, 2024

Artifacts upload triggered. View details here

Copy link

github-actions bot commented Nov 3, 2024

Artifacts upload triggered. View details here

Copy link

github-actions bot commented Nov 3, 2024

Artifacts upload triggered. View details here

commit-id:6e60b8d4
Copy link

github-actions bot commented Nov 4, 2024

Artifacts upload triggered. View details here

@github-actions github-actions bot locked and limited conversation to collaborators Nov 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants