Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(network): fix secret key length in test util #1774

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

dan-starkware
Copy link
Collaborator

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@dan-starkware dan-starkware marked this pull request as ready for review November 3, 2024 18:49
Copy link

codecov bot commented Nov 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.26%. Comparing base (e3165c4) to head (b6ee98f).
Report is 209 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1774      +/-   ##
==========================================
- Coverage   40.10%   35.26%   -4.84%     
==========================================
  Files          26       53      +27     
  Lines        1895     4846    +2951     
  Branches     1895     4846    +2951     
==========================================
+ Hits          760     1709     +949     
- Misses       1100     3081    +1981     
- Partials       35       56      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dan-starkware)

Copy link
Collaborator Author

dan-starkware commented Nov 5, 2024

Merge activity

  • Nov 5, 10:10 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Nov 5, 10:10 AM EST: A user merged this pull request with Graphite.

@dan-starkware dan-starkware merged commit cea57f5 into main Nov 5, 2024
17 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants