chore(consensus): add network config

[dan-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[dan-starkware]

• test: add consensus to e2e flow test #1811
• feat(consensus): send proposal content #1810
• feat(consensus): run network manager in consensus #1809
• chore(consensus): add network config #1808 👈
• chore: rename proposal init and add log #1807
• chore: add target in fmt layer #1806
• fix(network): fix secret key length in test util #1774
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @dan-starkware and the rest of your teammates on Graphite

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 11.74%. Comparing base (e3165c4) to head (8e6331c).
Report is 234 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #1808       +/-   ##
===========================================
- Coverage   40.10%   11.74%   -28.36%     
===========================================
  Files          26      286      +260     
  Lines        1895    33348    +31453     
  Branches     1895    33348    +31453     
===========================================
+ Hits          760     3918     +3158     
- Misses       1100    29167    +28067     
- Partials       35      263      +228     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ShahakShama]

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dan-starkware, @Itay-Tsabary-Starkware, and @matan-starkware)

---

crates/sequencing/papyrus_consensus/src/config.rs line 84 at r1 (raw file):

impl Default for ConsensusConfig {
    fn default() -> Self {
        let mut network_config = NetworkConfig::default();

consider instead

let network_config = NetworkConfig {
    tcp_port: 10100,
    quic_port: 10101,
    ..Default::default()
};

[dan-starkware]

crates/sequencing/papyrus_consensus/src/config.rs line 84 at r1 (raw file):

Previously, ShahakShama wrote…

consider instead

let network_config = NetworkConfig {
    tcp_port: 10100,
    quic_port: 10101,
    ..Default::default()
};

I don't think it can work since secret key is private

[Itay-Tsabary-Starkware]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @dan-starkware, @matan-starkware, and @ShahakShama)

---

crates/sequencing/papyrus_consensus/src/config.rs line 87 at r1 (raw file):

        // TODO(Dan/Shahak): consider something nicer, maybe a builder?
        network_config.tcp_port = 10100;
        network_config.quic_port = 10101;

Can these be made the default values of NetworkConfig?

Code quote:

        network_config.tcp_port = 10100;
        network_config.quic_port = 10101;

[dan-starkware]

crates/sequencing/papyrus_consensus/src/config.rs line 87 at r1 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

Can these be made the default values of NetworkConfig?

WDYM?
They are set this way in
config/papyrus/default_config.json

[Itay-Tsabary-Starkware]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @dan-starkware, @matan-starkware, and @ShahakShama)

---

crates/sequencing/papyrus_consensus/src/config.rs line 87 at r1 (raw file):

Previously, dan-starkware wrote…

WDYM?
They are set this way in
config/papyrus/default_config.json

Can NetworkConfig::default() return a struct whose values are

tcp_port = 10100;
quic_port = 10101;

?

[dan-starkware]

crates/sequencing/papyrus_consensus/src/config.rs line 87 at r1 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

Can NetworkConfig::default() return a struct whose values are

tcp_port = 10100;
quic_port = 10101;

?

IMO, since we have more than one component that's using it, each component should have different default values.

[matan-starkware]

aa

[Itay-Tsabary-Starkware]

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @dan-starkware and @ShahakShama)

[dan-starkware]

Reviewable status: 3 of 4 files reviewed, 3 unresolved discussions (waiting on @Itay-Tsabary-Starkware, @matan-starkware, and @ShahakShama)

---

crates/sequencing/papyrus_consensus/src/config.rs line 37 at r1 (raw file):

Previously, matan-starkware wrote…

If it's just adding a macro annotation, why not do that now?

I'm not sure what is the right validation (and whether one is needed) for each field.
I suggest to do it for all of the fields in a designated PR

---

crates/sequencing/papyrus_consensus/src/config.rs line 85 at r1 (raw file):

Previously, matan-starkware wrote…

How did you choose these ports?
We have a utility for selecting a free port find_free_port.
If you prefer the constants, should we move these to the top of the file instead of inline magic numbers?

Agree. There should be a constants source somewhere, for now just moving to local consts

[dan-starkware]

Reviewed all commit messages.
Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @Itay-Tsabary-Starkware and @ShahakShama)

[guy-starkware]

Reviewable status: 0 of 6 files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware, @matan-starkware, and @ShahakShama)

[matan-starkware]

Reviewed 1 of 1 files at r2, 5 of 5 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dan-starkware)