Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(starknet_api): rename executable tx to account tx #1787

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

yair-starkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@yair-starkware yair-starkware requested a review from alonh5 November 4, 2024 12:23
@yair-starkware yair-starkware marked this pull request as ready for review November 4, 2024 12:24
@yair-starkware yair-starkware force-pushed the yair/rename_executable_tx branch from 4d00569 to dd144cb Compare November 4, 2024 13:23
@yair-starkware yair-starkware self-assigned this Nov 4, 2024
@yair-starkware yair-starkware force-pushed the yair/rename_executable_tx branch from dd144cb to dc514f9 Compare November 4, 2024 13:28
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.

Project coverage is 50.25%. Comparing base (e3165c4) to head (7ad1b50).
Report is 232 commits behind head on main.

Files with missing lines Patch % Lines
crates/starknet_api/src/executable_transaction.rs 0.00% 15 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1787       +/-   ##
===========================================
+ Coverage   40.10%   50.25%   +10.14%     
===========================================
  Files          26       25        -1     
  Lines        1895     2553      +658     
  Branches     1895     2553      +658     
===========================================
+ Hits          760     1283      +523     
- Misses       1100     1205      +105     
- Partials       35       65       +30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ArniStarkware ArniStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @alonh5)

Copy link
Collaborator

@alonh5 alonh5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @yair-starkware)

Copy link
Collaborator

@alonh5 alonh5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @yair-starkware)

Copy link
Contributor

@ArniStarkware ArniStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @yair-starkware)

@ArniStarkware
Copy link
Contributor

crates/starknet_api/src/executable_transaction.rs line 128 at r2 (raw file):

        sender_address: ContractAddress,
    ) -> AccountTransaction {
        AccountTransaction::Invoke(crate::executable_transaction::InvokeTransaction {

there should be a merge conflict here.

Code quote:

    // TODO(Arni): Update the function to support all transaction types.
    pub fn new_from_rpc_tx(
        rpc_tx: RpcTransaction,
        tx_hash: TransactionHash,
        sender_address: ContractAddress,
    ) -> AccountTransaction {
        AccountTransaction::Invoke(crate::executable_transaction::InvokeTransaction {

Copy link
Contributor

@ArniStarkware ArniStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @alonh5)

@yair-starkware yair-starkware merged commit 5a28eb1 into main Nov 7, 2024
13 checks passed
Copy link
Contributor Author

Merge activity

  • Nov 7, 4:58 AM EST: A user merged this pull request with Graphite.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants