Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(l1-provider): use the correct tx type + fix crate package #1791

Merged
merged 1 commit into from
Nov 10, 2024
Merged

chore(l1-provider): use the correct tx type + fix crate package #1791

merged 1 commit into from
Nov 10, 2024

Conversation

yair-starkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@yair-starkware yair-starkware mentioned this pull request Nov 4, 2024
Merged
@yair-starkware Graphite App
Copy link
Contributor Author

yair-starkware commented Nov 4, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @yair-starkware and the rest of your teammates on Graphite Graphite

@yair-starkware yair-starkware mentioned this pull request Nov 4, 2024
Merged
@yair-starkware yair-starkware marked this pull request as ready for review November 4, 2024 13:45
@yair-starkware yair-starkware self-assigned this Nov 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 4, 2024

Artifacts upload triggered. View details here

@yair-starkware yair-starkware force-pushed the yair/executable_tx_enum branch from cff8057 to b0da47a Compare November 4, 2024 13:57
@yair-starkware yair-starkware force-pushed the yair/l1provider_tx_type branch from 0181e37 to 43e58cd Compare November 4, 2024 13:57
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 4, 2024

Artifacts upload triggered. View details here

@codecov Codecov
Copy link

codecov bot commented Nov 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.72%. Comparing base (e3165c4) to head (36d8ad4).
Report is 273 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #1791       +/-   ##
===========================================
+ Coverage   40.10%   76.72%   +36.61%     
===========================================
  Files          26      369      +343     
  Lines        1895    39300    +37405     
  Branches     1895    39300    +37405     
===========================================
+ Hits          760    30151    +29391     
- Misses       1100     6887     +5787     
- Partials       35     2262     +2227

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

alonh5
alonh5 approved these changes Nov 4, 2024
View reviewed changes
Copy link
Collaborator

@alonh5 alonh5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @giladchase)

@yair-starkware yair-starkware force-pushed the yair/executable_tx_enum branch from b0da47a to 6201fee Compare November 7, 2024 08:59
@yair-starkware yair-starkware force-pushed the yair/l1provider_tx_type branch from 43e58cd to bfe5389 Compare November 7, 2024 08:59
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2024

Artifacts upload triggered. View details here

@yair-starkware yair-starkware force-pushed the yair/executable_tx_enum branch from 6201fee to 1a245f8 Compare November 7, 2024 09:26
@yair-starkware yair-starkware force-pushed the yair/l1provider_tx_type branch from bfe5389 to 2617c1b Compare November 7, 2024 09:26
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2024

Artifacts upload triggered. View details here

@yair-starkware yair-starkware force-pushed the yair/executable_tx_enum branch from 1a245f8 to c944056 Compare November 7, 2024 09:36
@yair-starkware yair-starkware force-pushed the yair/l1provider_tx_type branch from 2617c1b to eae6d71 Compare November 7, 2024 09:36
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2024

Artifacts upload triggered. View details here

@yair-starkware yair-starkware force-pushed the yair/executable_tx_enum branch from c944056 to 1641e09 Compare November 7, 2024 09:49
@yair-starkware yair-starkware force-pushed the yair/l1provider_tx_type branch from eae6d71 to 318ed66 Compare November 7, 2024 09:49
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2024

Artifacts upload triggered. View details here

@yair-starkware yair-starkware force-pushed the yair/executable_tx_enum branch 2 times, most recently from 7bba7db to 75fcd63 Compare November 7, 2024 09:58
@yair-starkware yair-starkware force-pushed the yair/l1provider_tx_type branch from 318ed66 to 697d79a Compare November 7, 2024 09:59
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2024

Artifacts upload triggered. View details here

@yair-starkware yair-starkware changed the base branch from yair/executable_tx_enum to graphite-base/1791 November 7, 2024 11:14
@yair-starkware yair-starkware force-pushed the yair/l1provider_tx_type branch from 697d79a to ec8b5da Compare November 7, 2024 11:14
@yair-starkware yair-starkware changed the base branch from graphite-base/1791 to main November 7, 2024 11:14
@yair-starkware yair-starkware force-pushed the yair/l1provider_tx_type branch from ec8b5da to 24010a5 Compare November 7, 2024 11:14
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2024

Artifacts upload triggered. View details here

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2024

Artifacts upload triggered. View details here

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2024

Artifacts upload triggered. View details here

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2024

Artifacts upload triggered. View details here

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2024

Artifacts upload triggered. View details here

This was referenced Nov 7, 2024
Merged
Merged
@yair-starkware yair-starkware force-pushed the yair/l1provider_tx_type branch from 24010a5 to 56c06d5 Compare November 10, 2024 10:29
@github-actions GitHub Actions
Copy link

Artifacts upload triggered. View details here

@yair-starkware yair-starkware force-pushed the yair/l1provider_tx_type branch from 56c06d5 to 36d8ad4 Compare November 10, 2024 12:31
@github-actions GitHub Actions
Copy link

Artifacts upload triggered. View details here

@yair-starkware yair-starkware mentioned this pull request Nov 10, 2024
Merged
alonh5
alonh5 approved these changes Nov 10, 2024
View reviewed changes
Copy link
Collaborator

@alonh5 alonh5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @giladchase)

@yair-starkware yair-starkware merged commit 6bb1761 into main Nov 10, 2024
22 checks passed
@yair-starkware Graphite App
Copy link
Contributor Author

Merge activity

  • Nov 10, 8:20 AM EST: A user merged this pull request with Graphite.

@yair-starkware yair-starkware mentioned this pull request Nov 10, 2024
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Nov 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alonh5 alonh5 alonh5 approved these changes

@giladchase giladchase Awaiting requested review from giladchase

Assignees

@yair-starkware yair-starkware

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yair-starkware @reviewable-StarkWare @alonh5