Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use the exeutable deploy_account tx create test util for blockifier test util #1919

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

ArniStarkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor Author

ArniStarkware commented Nov 10, 2024

@ArniStarkware ArniStarkware marked this pull request as ready for review November 10, 2024 14:02
Copy link

Artifacts upload triggered. View details here

Copy link

codecov bot commented Nov 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.00%. Comparing base (e3165c4) to head (2cf3d70).
Report is 287 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1919      +/-   ##
==========================================
+ Coverage   40.10%   49.00%   +8.89%     
==========================================
  Files          26      195     +169     
  Lines        1895    23300   +21405     
  Branches     1895    23300   +21405     
==========================================
+ Hits          760    11418   +10658     
- Misses       1100    11367   +10267     
- Partials       35      515     +480     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@dafnamatsry dafnamatsry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @avivg-starkware and @MohammadNassar1)

@ArniStarkware ArniStarkware merged commit 1224df1 into main Nov 11, 2024
15 checks passed
@ArniStarkware ArniStarkware deleted the arni/test_utils/deploy_account/blockifier branch November 11, 2024 08:30
@github-actions github-actions bot locked and limited conversation to collaborators Nov 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants