test: streamline the v0 version tx for invoke tx towards code dedup in test utils

[ArniStarkware]

This change is 

[ArniStarkware]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• test: use the exeutable tx creator test util for the account tx creator test util #749
• test: streamline the v0 version tx for invoke tx towards code dedup in test utils #747 👈
• test: use the exeutable deploy_account tx create test util for blockifier test util #1919
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ArniStarkware and the rest of your teammates on Graphite

[github-actions]

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [65.458 ms 65.718 ms 66.130 ms]
change: [-8.8578% -5.4025% -2.3102%] (p = 0.00 < 0.05)
Performance has improved.
Found 9 outliers among 100 measurements (9.00%)
3 (3.00%) high mild
6 (6.00%) high severe

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.61%. Comparing base (2cf3d70) to head (fd8a886).

Additional details and impacted files

@@                              Coverage Diff                               @@
##           arni/test_utils/deploy_account/blockifier     #747       +/-   ##
==============================================================================
+ Coverage                                      49.00%   76.61%   +27.61%     
==============================================================================
  Files                                            195      102       -93     
  Lines                                          23300    13677     -9623     
  Branches                                       23300    13677     -9623     
==============================================================================
- Hits                                           11418    10479      -939     
+ Misses                                         11367     2742     -8625     
+ Partials                                         515      456       -59     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [66.337 ms 66.401 ms 66.473 ms]
change: [-8.3913% -5.1461% -2.2775%] (p = 0.00 < 0.05)
Performance has improved.
Found 2 outliers among 100 measurements (2.00%)
2 (2.00%) high severe

[github-actions]

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [66.467 ms 66.569 ms 66.674 ms]
change: [-8.9706% -5.7897% -3.1217%] (p = 0.00 < 0.05)
Performance has improved.
Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high severe

[MohammadNassar1]

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @ArniStarkware)

a discussion (no related file):
Can you please explain the change here?
Why does V0 have a special treatment, and why is it no longer necessary?

---

[ArniStarkware]

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @MohammadNassar1)

a discussion (no related file):
For version 0 transactions, the field entry_point_selector must always be a specific thing:

/// V0 transactions should always select the __execute__ entry point.
/// The original code from the blockifier crate was:

To compute the entry point selector value, you must use functions specifically from blockifier::abi::abi_utils, namely: selector_from_name. In this PR, we compute the value manually, offline, and hard code it in SNAPI.

The question becomes do we want to avoid this hard coding of a value.
The other thing we can do is move the abi utils into snapi.
Stuff like moving the function starknet_keccak into snapi - which might be fair game....

---

[ArniStarkware]

crates/starknet_api/src/test_utils/invoke.rs line 79 at r3 (raw file):

}

static EXECUTE_ENTRY_POINT_SELECTOR: OnceLock<EntryPointSelector> = OnceLock::new();

Use lazylock

Code quote:

static EXECUTE_ENTRY_POINT_SELECTOR: OnceLock<EntryPointSelector> = OnceLock::new();

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Benchmark movements:
tree_computation_flow performance regressed!
tree_computation_flow time: [34.717 ms 35.025 ms 35.393 ms]
change: [+1.2448% +2.1121% +3.0844%] (p = 0.00 < 0.05)
Performance has regressed.
Found 20 outliers among 100 measurements (20.00%)
4 (4.00%) high mild
16 (16.00%) high severe

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here