Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(blockifier_reexecution): inject chain ID to chain info creation #1970

Conversation

dorimedini-starkware
Copy link
Collaborator

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 41.16%. Comparing base (e3165c4) to head (716bed2).
Report is 356 commits behind head on main.

Files with missing lines Patch % Lines
...s/blockifier_reexecution/src/state_reader/utils.rs 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1970      +/-   ##
==========================================
+ Coverage   40.10%   41.16%   +1.05%     
==========================================
  Files          26      198     +172     
  Lines        1895    23751   +21856     
  Branches     1895    23751   +21856     
==========================================
+ Hits          760     9777    +9017     
- Misses       1100    13516   +12416     
- Partials       35      458     +423     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dorimedini-starkware dorimedini-starkware force-pushed the 11-12-refactor_blockifier_reexecution_inject_chain_id_to_chain_info_creation branch from dbf7b4a to 716bed2 Compare November 12, 2024 08:40
Copy link
Contributor

@aner-starkware aner-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)

Copy link
Collaborator Author

dorimedini-starkware commented Nov 13, 2024

Merge activity

  • Nov 13, 6:13 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Nov 13, 6:14 AM EST: A user merged this pull request with Graphite.

@dorimedini-starkware dorimedini-starkware merged commit a68a0e0 into main Nov 13, 2024
10 checks passed
Copy link
Contributor

@AvivYossef-starkware AvivYossef-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@github-actions github-actions bot locked and limited conversation to collaborators Nov 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants