refactor(blockifier_reexecution): set chain ID by inspecting RPC URL #1973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
This was referenced Nov 12, 2024
This was referenced Nov 12, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1973 +/- ##
==========================================
+ Coverage 40.10% 42.15% +2.05%
==========================================
Files 26 204 +178
Lines 1895 23946 +22051
Branches 1895 23946 +22051
==========================================
+ Hits 760 10095 +9335
- Misses 1100 13385 +12285
- Partials 35 466 +431 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
dorimedini-starkware
force-pushed
the
11-12-refactor_blockifier_reexecution_add_chain_id_to_serializableofflinereexecutiondata
branch
from
c4c7ff2 to
a4d664b
Compare
dorimedini-starkware
force-pushed
the
11-12-refactor_blockifier_reexecution_set_chain_id_by_inspecting_rpc_url
branch
from
fb4736b to
f729381
Compare
dorimedini-starkware
force-pushed
the
11-12-refactor_blockifier_reexecution_add_chain_id_to_serializableofflinereexecutiondata
branch
from
a4d664b to
74cb405
Compare
dorimedini-starkware
force-pushed
the
11-12-refactor_blockifier_reexecution_set_chain_id_by_inspecting_rpc_url
branch
from
f729381 to
69a7f44
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
dorimedini-starkware
force-pushed
the
11-12-refactor_blockifier_reexecution_set_chain_id_by_inspecting_rpc_url
branch
from
69a7f44 to
773ca69
Compare
There was a problem hiding this comment.
Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @aner-starkware and @graphite-app[bot])
dorimedini-starkware
force-pushed
the
11-12-refactor_blockifier_reexecution_add_chain_id_to_serializableofflinereexecutiondata
branch
from
74cb405 to
141a523
Compare
dorimedini-starkware
force-pushed
the
11-12-refactor_blockifier_reexecution_set_chain_id_by_inspecting_rpc_url
branch
from
773ca69 to
78e7e2b
Compare
AvivYossef-starkware
approved these changes
Nov 13, 2024
There was a problem hiding this comment.
Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @aner-starkware and @graphite-app[bot])
dorimedini-starkware
force-pushed
the
11-12-refactor_blockifier_reexecution_add_chain_id_to_serializableofflinereexecutiondata
branch
from
141a523 to
0c076ba
Compare
dorimedini-starkware
force-pushed
the
11-12-refactor_blockifier_reexecution_set_chain_id_by_inspecting_rpc_url
branch
from
78e7e2b to
174825a
Compare
aner-starkware
approved these changes
Nov 18, 2024
There was a problem hiding this comment.
Reviewed 1 of 4 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @graphite-app[bot])
dorimedini-starkware
force-pushed
the
11-12-refactor_blockifier_reexecution_add_chain_id_to_serializableofflinereexecutiondata
branch
from
0c076ba to
c40fd02
Compare
dorimedini-starkware
force-pushed
the
11-12-refactor_blockifier_reexecution_set_chain_id_by_inspecting_rpc_url
branch
from
174825a to
cde3a37
Compare
dorimedini-starkware
force-pushed
the
11-12-refactor_blockifier_reexecution_add_chain_id_to_serializableofflinereexecutiondata
branch
from
c40fd02 to
db6726d
Compare
dorimedini-starkware
force-pushed
the
11-12-refactor_blockifier_reexecution_set_chain_id_by_inspecting_rpc_url
branch
3 times, most recently
from
e1fcf93 to
c02325e
Compare
aner-starkware
approved these changes
Nov 19, 2024
There was a problem hiding this comment.
Reviewed 3 of 3 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @graphite-app[bot])
There was a problem hiding this comment.
Dismissed @graphite-app[bot] from a discussion.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)
dorimedini-starkware
force-pushed
the
11-12-refactor_blockifier_reexecution_add_chain_id_to_serializableofflinereexecutiondata
branch
2 times, most recently
from
60702e2 to
ac4acfa
Compare
dorimedini-starkware
force-pushed
the
11-12-refactor_blockifier_reexecution_set_chain_id_by_inspecting_rpc_url
branch
2 times, most recently
from
65f0624 to
996cec8
Compare
dorimedini-starkware
changed the base branch from
11-12-refactor_blockifier_reexecution_add_chain_id_to_serializableofflinereexecutiondata
to
graphite-base/1973
dorimedini-starkware
changed the base branch from
graphite-base/1973
to
main
dorimedini-starkware
force-pushed
the
11-12-refactor_blockifier_reexecution_set_chain_id_by_inspecting_rpc_url
branch
from
996cec8 to
da371da
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.