chore(blockifier): slight diff impl for AccountTransaction getters #2102

avivg-starkware · 2024-11-17T10:57:42Z

No description provided.

reviewable-StarkWare · 2024-11-17T10:57:46Z

This change is

avivg-starkware · 2024-11-17T10:57:56Z

This stack of pull requests is managed by Graphite. Learn more about stacking.

github-actions · 2024-11-17T10:59:22Z

Artifacts upload triggered. View details here

github-actions · 2024-11-17T10:59:58Z

Artifacts upload triggered. View details here

github-actions · 2024-11-17T11:18:16Z

Artifacts upload triggered. View details here

github-actions · 2024-11-17T11:27:49Z

Benchmark movements:
tree_computation_flow performance regressed!
tree_computation_flow time: [34.785 ms 35.263 ms 35.832 ms]
change: [+1.0882% +2.5036% +4.2812%] (p = 0.00 < 0.05)
Performance has regressed.
Found 10 outliers among 100 measurements (10.00%)
2 (2.00%) high mild
8 (8.00%) high severe

codecov · 2024-11-17T11:58:48Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.88%. Comparing base (e3165c4) to head (09a82c9).
Report is 603 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #2102       +/-   ##
===========================================
+ Coverage   40.10%   76.88%   +36.77%     
===========================================
  Files          26      110       +84     
  Lines        1895    13945    +12050     
  Branches     1895    13945    +12050     
===========================================
+ Hits          760    10721     +9961     
- Misses       1100     2759     +1659     
- Partials       35      465      +430

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2024-11-17T12:36:20Z

Artifacts upload triggered. View details here

github-actions · 2024-11-17T12:42:14Z

Artifacts upload triggered. View details here

github-actions · 2024-11-17T12:53:20Z

Artifacts upload triggered. View details here

github-actions · 2024-11-17T13:55:29Z

Artifacts upload triggered. View details here

github-actions · 2024-11-17T14:03:42Z

Benchmark movements:
full_committer_flow performance improved 😺
full_committer_flow time: [30.112 ms 30.191 ms 30.280 ms]
change: [-2.6414% -1.7863% -1.1287%] (p = 0.00 < 0.05)
Performance has improved.
Found 8 outliers among 100 measurements (8.00%)
6 (6.00%) high mild
2 (2.00%) high severe

Yoni-Starkware

Cool!

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @avivg-starkware)

github-actions · 2024-11-20T16:05:19Z

Artifacts upload triggered. View details here

Yoni-Starkware

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @avivg-starkware)

github-actions · 2024-11-27T09:43:56Z

Artifacts upload workflows:

github-actions · 2024-11-27T10:33:24Z

Benchmark movements:
tree_computation_flow performance regressed!
tree_computation_flow time: [34.604 ms 35.076 ms 35.625 ms]
change: [+2.5370% +3.7553% +5.8111%] (p = 0.00 < 0.05)
Performance has regressed.
Found 8 outliers among 100 measurements (8.00%)
1 (1.00%) high mild
7 (7.00%) high severe

Yoni-Starkware

Reviewed all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @avivg-starkware)

github-actions · 2024-11-27T12:55:12Z

Benchmark movements:
full_committer_flow performance improved 😺
full_committer_flow time: [29.575 ms 29.658 ms 29.766 ms]
change: [-2.3417% -1.9853% -1.5770%] (p = 0.00 < 0.05)
Performance has improved.
Found 5 outliers among 100 measurements (5.00%)
5 (5.00%) high severe

avivg-starkware mentioned this pull request Nov 17, 2024

chore(blockifier): remove dupl tip() and resource_bounds() in AccountTx #2101

Merged

avivg-starkware marked this pull request as ready for review November 17, 2024 10:58

avivg-starkware force-pushed the avivg/blockifier/refactor_account_tx_tip_resource_bounds branch from 20f4544 to ca92528 Compare November 17, 2024 10:58

avivg-starkware force-pushed the avivg/blockifier/account_tx_getters_impl branch from d654aae to 092ec00 Compare November 17, 2024 10:58

avivg-starkware force-pushed the avivg/blockifier/refactor_account_tx_tip_resource_bounds branch from ca92528 to fae60a0 Compare November 17, 2024 11:17

avivg-starkware force-pushed the avivg/blockifier/account_tx_getters_impl branch from 092ec00 to 22d25b7 Compare November 17, 2024 11:17

avivg-starkware force-pushed the avivg/blockifier/refactor_account_tx_tip_resource_bounds branch from fae60a0 to b436fef Compare November 17, 2024 12:34

avivg-starkware force-pushed the avivg/blockifier/account_tx_getters_impl branch from 22d25b7 to a5ee9e1 Compare November 17, 2024 12:34

avivg-starkware changed the base branch from avivg/blockifier/refactor_account_tx_tip_resource_bounds to avivg/blockifier/use_macro_sender_addr_tx_hash November 17, 2024 12:34

This was referenced Nov 17, 2024

chore(blockifier): a simple code cleanup in signature_length() #2108

Merged

chore(blockifier): use macro in AccounTx::{sender_address(), tx_hash()} #2109

Merged

avivg-starkware force-pushed the avivg/blockifier/account_tx_getters_impl branch from a5ee9e1 to e0b31f8 Compare November 17, 2024 12:52

avivg-starkware requested a review from Yoni-Starkware November 17, 2024 13:10

avivg-starkware force-pushed the avivg/blockifier/use_macro_sender_addr_tx_hash branch from ed4f424 to a3f457a Compare November 17, 2024 13:53

avivg-starkware force-pushed the avivg/blockifier/account_tx_getters_impl branch from e0b31f8 to a7457ea Compare November 17, 2024 13:53

Yoni-Starkware approved these changes Nov 17, 2024

View reviewed changes

avivg-starkware force-pushed the avivg/blockifier/use_macro_sender_addr_tx_hash branch from a3f457a to 5b6c212 Compare November 20, 2024 16:03

avivg-starkware force-pushed the avivg/blockifier/account_tx_getters_impl branch from a7457ea to ab1f379 Compare November 20, 2024 16:03

Yoni-Starkware approved these changes Nov 20, 2024

View reviewed changes

avivg-starkware force-pushed the avivg/blockifier/use_macro_sender_addr_tx_hash branch from 5b6c212 to f738ed6 Compare November 27, 2024 09:42

avivg-starkware force-pushed the avivg/blockifier/account_tx_getters_impl branch from ab1f379 to 633ca17 Compare November 27, 2024 09:42

avivg-starkware force-pushed the avivg/blockifier/use_macro_sender_addr_tx_hash branch from f738ed6 to c5b0668 Compare November 27, 2024 09:58

avivg-starkware force-pushed the avivg/blockifier/account_tx_getters_impl branch from 633ca17 to ea624cc Compare November 27, 2024 09:59

avivg-starkware force-pushed the avivg/blockifier/use_macro_sender_addr_tx_hash branch from c5b0668 to 0664623 Compare November 27, 2024 10:18

avivg-starkware force-pushed the avivg/blockifier/account_tx_getters_impl branch from ea624cc to 7bbd69b Compare November 27, 2024 10:18

avivg-starkware changed the title ~~chore(blockifier): consider slightly different implementation of account tx getters~~ chore(blockifier): slight diff impl for AccountTransaction getters Nov 27, 2024

avivg-starkware force-pushed the avivg/blockifier/use_macro_sender_addr_tx_hash branch 2 times, most recently from 714f261 to b9ab129 Compare November 27, 2024 11:15

avivg-starkware force-pushed the avivg/blockifier/account_tx_getters_impl branch from 7bbd69b to a74f9fd Compare November 27, 2024 11:15

Yoni-Starkware approved these changes Nov 27, 2024

View reviewed changes

avivg-starkware changed the base branch from avivg/blockifier/use_macro_sender_addr_tx_hash to graphite-base/2102 November 27, 2024 12:43

avivg-starkware force-pushed the avivg/blockifier/account_tx_getters_impl branch from a74f9fd to b2d59ab Compare November 27, 2024 12:43

avivg-starkware force-pushed the graphite-base/2102 branch from b9ab129 to 5e79710 Compare November 27, 2024 12:43

avivg-starkware changed the base branch from graphite-base/2102 to main November 27, 2024 12:44

chore(blockifier): slight diff impl for AccountTransaction getters

09a82c9

avivg-starkware force-pushed the avivg/blockifier/account_tx_getters_impl branch from b2d59ab to 09a82c9 Compare November 27, 2024 12:44

avivg-starkware merged commit 0165282 into main Nov 27, 2024
16 checks passed

avivg-starkware deleted the avivg/blockifier/account_tx_getters_impl branch November 27, 2024 13:11

github-actions bot locked and limited conversation to collaborators Nov 29, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(blockifier): slight diff impl for AccountTransaction getters #2102

chore(blockifier): slight diff impl for AccountTransaction getters #2102

avivg-starkware commented Nov 17, 2024

reviewable-StarkWare commented Nov 17, 2024

avivg-starkware commented Nov 17, 2024 •

edited

Loading

github-actions bot commented Nov 17, 2024

github-actions bot commented Nov 17, 2024

github-actions bot commented Nov 17, 2024

github-actions bot commented Nov 17, 2024

codecov bot commented Nov 17, 2024 •

edited

Loading

github-actions bot commented Nov 17, 2024

github-actions bot commented Nov 17, 2024

github-actions bot commented Nov 17, 2024

github-actions bot commented Nov 17, 2024

github-actions bot commented Nov 17, 2024

Yoni-Starkware left a comment

github-actions bot commented Nov 20, 2024

Yoni-Starkware left a comment

github-actions bot commented Nov 27, 2024 •

edited

Loading

github-actions bot commented Nov 27, 2024

Yoni-Starkware left a comment

github-actions bot commented Nov 27, 2024

chore(blockifier): slight diff impl for AccountTransaction getters #2102

chore(blockifier): slight diff impl for AccountTransaction getters #2102

Conversation

avivg-starkware commented Nov 17, 2024

reviewable-StarkWare commented Nov 17, 2024

avivg-starkware commented Nov 17, 2024 • edited Loading

github-actions bot commented Nov 17, 2024

github-actions bot commented Nov 17, 2024

github-actions bot commented Nov 17, 2024

github-actions bot commented Nov 17, 2024

codecov bot commented Nov 17, 2024 • edited Loading

Codecov Report

github-actions bot commented Nov 17, 2024

github-actions bot commented Nov 17, 2024

github-actions bot commented Nov 17, 2024

github-actions bot commented Nov 17, 2024

github-actions bot commented Nov 17, 2024

Yoni-Starkware left a comment

Choose a reason for hiding this comment

github-actions bot commented Nov 20, 2024

Yoni-Starkware left a comment

Choose a reason for hiding this comment

github-actions bot commented Nov 27, 2024 • edited Loading

github-actions bot commented Nov 27, 2024

Yoni-Starkware left a comment

Choose a reason for hiding this comment

github-actions bot commented Nov 27, 2024

avivg-starkware commented Nov 17, 2024 •

edited

Loading

codecov bot commented Nov 17, 2024 •

edited

Loading

github-actions bot commented Nov 27, 2024 •

edited

Loading