Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(blockifier): use macro in AccounTx::{sender_address(), tx_hash()} #2109

Merged
merged 1 commit into from
Nov 27, 2024
Merged

chore(blockifier): use macro in AccounTx::{sender_address(), tx_hash()} #2109

merged 1 commit into from
Nov 27, 2024

Conversation

avivg-starkware
Copy link
Contributor

No description provided.

@avivg-starkware avivg-starkware mentioned this pull request Nov 17, 2024
Merged
@reviewable-StarkWare
Copy link

This change is Reviewable

@avivg-starkware Graphite App
Copy link
Contributor Author

avivg-starkware commented Nov 17, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Nov 17, 2024
Merged
Merged
@avivg-starkware avivg-starkware marked this pull request as ready for review November 17, 2024 12:35
@github-actions GitHub Actions
Copy link

Artifacts upload triggered. View details here

@codecov Codecov
Copy link

codecov bot commented Nov 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.88%. Comparing base (e3165c4) to head (b9ab129).
Report is 598 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #2109       +/-   ##
===========================================
+ Coverage   40.10%   68.88%   +28.77%     
===========================================
  Files          26      108       +82     
  Lines        1895    13921    +12026     
  Branches     1895    13921    +12026     
===========================================
+ Hits          760     9589     +8829     
- Misses       1100     3921     +2821     
- Partials       35      411      +376

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@avivg-starkware avivg-starkware force-pushed the avivg/blockifier/refactor_account_tx_tip_resource_bounds branch from b436fef to 17fc2be Compare November 17, 2024 13:53
@avivg-starkware avivg-starkware force-pushed the avivg/blockifier/use_macro_sender_addr_tx_hash branch from ed4f424 to a3f457a Compare November 17, 2024 13:53
@github-actions GitHub Actions
Copy link

Artifacts upload triggered. View details here

Yoni-Starkware
Yoni-Starkware approved these changes Nov 17, 2024
View reviewed changes
Copy link
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @avivg-starkware)

@avivg-starkware avivg-starkware force-pushed the avivg/blockifier/refactor_account_tx_tip_resource_bounds branch from 17fc2be to ec2e90c Compare November 20, 2024 16:03
@avivg-starkware avivg-starkware force-pushed the avivg/blockifier/use_macro_sender_addr_tx_hash branch from a3f457a to 5b6c212 Compare November 20, 2024 16:03
@github-actions GitHub Actions
Copy link

Artifacts upload triggered. View details here

Yoni-Starkware
Yoni-Starkware approved these changes Nov 20, 2024
View reviewed changes
Copy link
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @avivg-starkware)

@avivg-starkware avivg-starkware force-pushed the avivg/blockifier/refactor_account_tx_tip_resource_bounds branch 2 times, most recently from 1a73e85 to eb22856 Compare November 27, 2024 09:42
@avivg-starkware avivg-starkware force-pushed the avivg/blockifier/use_macro_sender_addr_tx_hash branch from 5b6c212 to f738ed6 Compare November 27, 2024 09:42
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 27, 2024 •
edited
Loading

Artifacts upload workflows:

@avivg-starkware avivg-starkware force-pushed the avivg/blockifier/use_macro_sender_addr_tx_hash branch from f738ed6 to c5b0668 Compare November 27, 2024 09:58
@avivg-starkware avivg-starkware force-pushed the avivg/blockifier/refactor_account_tx_tip_resource_bounds branch from 1a73e85 to 855ade9 Compare November 27, 2024 10:18
@avivg-starkware avivg-starkware force-pushed the avivg/blockifier/use_macro_sender_addr_tx_hash branch from c5b0668 to 0664623 Compare November 27, 2024 10:18
@avivg-starkware avivg-starkware changed the title chore(blockifier): use macro for sender_address() and tx_hash() in AccountTransaction chore(blockifier): use macro in AccounTx::{sender_address(), tx_hash()} Nov 27, 2024
Yoni-Starkware
Yoni-Starkware approved these changes Nov 27, 2024
View reviewed changes
Copy link
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @avivg-starkware)

Yoni-Starkware
Yoni-Starkware approved these changes Nov 27, 2024
View reviewed changes
Copy link
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @avivg-starkware)

@avivg-starkware avivg-starkware changed the base branch from avivg/blockifier/refactor_account_tx_tip_resource_bounds to graphite-base/2109 November 27, 2024 11:14
@avivg-starkware avivg-starkware force-pushed the avivg/blockifier/use_macro_sender_addr_tx_hash branch from 0664623 to 714f261 Compare November 27, 2024 11:15
@avivg-starkware avivg-starkware changed the base branch from graphite-base/2109 to main November 27, 2024 11:15
@avivg-starkware avivg-starkware force-pushed the avivg/blockifier/use_macro_sender_addr_tx_hash branch from 714f261 to b9ab129 Compare November 27, 2024 11:15
@avivg-starkware avivg-starkware merged commit 5e79710 into main Nov 27, 2024
13 checks passed
@avivg-starkware avivg-starkware deleted the avivg/blockifier/use_macro_sender_addr_tx_hash branch November 27, 2024 13:11
@github-actions github-actions bot locked and limited conversation to collaborators Nov 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Yoni-Starkware Yoni-Starkware Yoni-Starkware approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@avivg-starkware @reviewable-StarkWare @Yoni-Starkware