Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: restrict RemoteServers struct and field visibility #2125

Open
wants to merge 1 commit into
base: spr/main/485ed888
Choose a base branch
from

Conversation

nadin-Starkware
Copy link
Collaborator

@nadin-Starkware nadin-Starkware commented Nov 17, 2024

Stack:

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

codecov bot commented Nov 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 5.93%. Comparing base (a015c8c) to head (1879f14).

Files with missing lines Patch % Lines
crates/starknet_sequencer_node/src/servers.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##           spr/main/485ed888   #2125       +/-   ##
=====================================================
- Coverage              77.42%   5.93%   -71.49%     
=====================================================
  Files                    381     263      -118     
  Lines                  40133   30622     -9511     
  Branches               40133   30622     -9511     
=====================================================
- Hits                   31071    1816    -29255     
- Misses                  6772   28732    +21960     
+ Partials                2290      74     -2216     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale.
This PR will be closed and locked in 7 days if no further activity occurs.
Thank you for your contributions!

@github-actions github-actions bot added the stale label Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants