Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support remote servers execution #2047

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Conversation

nadin-Starkware
Copy link
Collaborator

@nadin-Starkware nadin-Starkware commented Nov 14, 2024

commit-id:02b017c7


Stack:

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 45 lines in your changes missing coverage. Please review.

Project coverage is 5.93%. Comparing base (e3165c4) to head (b6c6bd3).
Report is 495 commits behind head on main.

Files with missing lines Patch % Lines
crates/starknet_sequencer_node/src/servers.rs 0.00% 44 Missing ⚠️
crates/starknet_sequencer_node/src/utils.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #2047       +/-   ##
==========================================
- Coverage   40.10%   5.93%   -34.17%     
==========================================
  Files          26     263      +237     
  Lines        1895   30586    +28691     
  Branches     1895   30586    +28691     
==========================================
+ Hits          760    1816     +1056     
- Misses       1100   28696    +27596     
- Partials       35      74       +39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@nadin-Starkware nadin-Starkware force-pushed the spr/main/02b017c7 branch 2 times, most recently from 19ee0d7 to 3d7f42a Compare November 14, 2024 11:06
@nadin-Starkware nadin-Starkware changed the title feat: add remote servers to the SequencerNodeServers feat: support remote servers execution Nov 14, 2024
@nadin-Starkware nadin-Starkware changed the base branch from spr/main/bce13ad1 to spr/main/45cc731f November 17, 2024 11:16
Copy link
Contributor

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 5 files reviewed, 1 unresolved discussion (waiting on @nadin-Starkware)


crates/starknet_sequencer_node/src/servers.rs line 327 at r2 (raw file):

    // Batcher servers.
    let local_batcher_future = get_server_future(servers.local_servers.batcher);
    let remote_batcher_future = get_server_future(servers.remote_servers.batcher);

I suggest we use indirection here. Please add each struct (remote, local, wrapper) a function to create its relevant futures.
Also please add a todo to spawn the tasks separately, and then join them in a cleaner manner.

Code quote:

    let local_batcher_future = get_server_future(servers.local_servers.batcher);
    let remote_batcher_future = get_server_future(servers.remote_servers.batcher);

@nadin-Starkware nadin-Starkware changed the base branch from spr/main/45cc731f to main November 17, 2024 16:01
Copy link

Artifacts upload triggered. View details here

Copy link
Contributor

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 5 files at r1, 4 of 4 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @nadin-Starkware)

@nadin-Starkware nadin-Starkware merged commit c3b9d96 into main Nov 19, 2024
10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants