-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support remote servers execution #2047
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2047 +/- ##
==========================================
- Coverage 40.10% 5.93% -34.17%
==========================================
Files 26 263 +237
Lines 1895 30586 +28691
Branches 1895 30586 +28691
==========================================
+ Hits 760 1816 +1056
- Misses 1100 28696 +27596
- Partials 35 74 +39 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
19ee0d7
to
3d7f42a
Compare
3d7f42a
to
1d8fe1c
Compare
ae3a146
to
7fccec0
Compare
1d8fe1c
to
d3dc1ea
Compare
d3dc1ea
to
214cdf6
Compare
5a4981d
to
84303e7
Compare
214cdf6
to
7d2d0b5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 5 files reviewed, 1 unresolved discussion (waiting on @nadin-Starkware)
crates/starknet_sequencer_node/src/servers.rs
line 327 at r2 (raw file):
// Batcher servers. let local_batcher_future = get_server_future(servers.local_servers.batcher); let remote_batcher_future = get_server_future(servers.remote_servers.batcher);
I suggest we use indirection here. Please add each struct (remote, local, wrapper) a function to create its relevant futures.
Also please add a todo to spawn the tasks separately, and then join them in a cleaner manner.
Code quote:
let local_batcher_future = get_server_future(servers.local_servers.batcher);
let remote_batcher_future = get_server_future(servers.remote_servers.batcher);
7d2d0b5
to
0a87122
Compare
Artifacts upload triggered. View details here |
0a87122
to
eeb3d75
Compare
commit-id:02b017c7
eeb3d75
to
b6c6bd3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 5 files at r1, 4 of 4 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @nadin-Starkware)
commit-id:02b017c7
Stack: