Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add client getters #2035

Closed
wants to merge 1 commit into from

Conversation

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 29 lines in your changes missing coverage. Please review.

Project coverage is 5.93%. Comparing base (f54ac47) to head (4a15085).

Files with missing lines Patch % Lines
crates/starknet_sequencer_node/src/clients.rs 0.00% 29 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##           spr/main/9bfa6756   #2035       +/-   ##
=====================================================
- Coverage              37.58%   5.93%   -31.66%     
=====================================================
  Files                    270     263        -7     
  Lines                  31159   30586      -573     
  Branches               31159   30586      -573     
=====================================================
- Hits                   11712    1816     -9896     
- Misses                 18435   28696    +10261     
+ Partials                1012      74      -938     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @nadin-Starkware)


crates/starknet_sequencer_node/src/clients.rs line 122 at r1 (raw file):

    pub fn get_gateway_client(&self) -> Option<&Client<GatewayRequest, GatewayResponse>> {
        self.gateway_client.as_ref()
    }

These names are too similar, and can be confusing.

Code quote:

    pub fn get_gateway_shared_client(&self) -> Option<SharedGatewayClient> {
        get_shared_client!(self, gateway_client)
    }

    pub fn get_gateway_client(&self) -> Option<&Client<GatewayRequest, GatewayResponse>> {
        self.gateway_client.as_ref()
    }

Copy link
Collaborator Author

@nadin-Starkware nadin-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @Itay-Tsabary-Starkware)


crates/starknet_sequencer_node/src/clients.rs line 122 at r1 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

These names are too similar, and can be confusing.

Agree, I updated the name and function implementation to return the local client, as required for the server.

commit-id:d27ad891
Copy link
Contributor

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @nadin-Starkware)

@nadin-Starkware
Copy link
Collaborator Author

✓ Commit merged in pull request #2041

@github-actions github-actions bot locked and limited conversation to collaborators Nov 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants