-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add client getters #2035
Conversation
52381f4
to
4a6727a
Compare
45d7358
to
3314e89
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## spr/main/9bfa6756 #2035 +/- ##
=====================================================
- Coverage 37.58% 5.93% -31.66%
=====================================================
Files 270 263 -7
Lines 31159 30586 -573
Branches 31159 30586 -573
=====================================================
- Hits 11712 1816 -9896
- Misses 18435 28696 +10261
+ Partials 1012 74 -938 ☔ View full report in Codecov by Sentry. |
3314e89
to
4bdccd2
Compare
4a6727a
to
3173bfe
Compare
3173bfe
to
74a56aa
Compare
4bdccd2
to
c568306
Compare
c568306
to
39ff694
Compare
74a56aa
to
17af05d
Compare
e090301
to
a5bcac1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @nadin-Starkware)
crates/starknet_sequencer_node/src/clients.rs
line 122 at r1 (raw file):
pub fn get_gateway_client(&self) -> Option<&Client<GatewayRequest, GatewayResponse>> { self.gateway_client.as_ref() }
These names are too similar, and can be confusing.
Code quote:
pub fn get_gateway_shared_client(&self) -> Option<SharedGatewayClient> {
get_shared_client!(self, gateway_client)
}
pub fn get_gateway_client(&self) -> Option<&Client<GatewayRequest, GatewayResponse>> {
self.gateway_client.as_ref()
}
a5bcac1
to
c3019d2
Compare
227611b
to
924db7c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @Itay-Tsabary-Starkware)
crates/starknet_sequencer_node/src/clients.rs
line 122 at r1 (raw file):
Previously, Itay-Tsabary-Starkware wrote…
These names are too similar, and can be confusing.
Agree, I updated the name and function implementation to return the local client, as required for the server.
commit-id:d27ad891
924db7c
to
f54ac47
Compare
c3019d2
to
4a15085
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @nadin-Starkware)
✓ Commit merged in pull request #2041 |
Stack: