chore: add remote server types #2032
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 13, 2024
|
This change is |
nadin-Starkware
force-pushed
the
spr/main/2ca0a7a3
branch
from
fb810bb to
d633d48
Compare
nadin-Starkware
force-pushed
the
spr/main/692fa745
branch
from
eda076e to
241a04d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## spr/main/2ca0a7a3 #2032 +/- ##
======================================================
+ Coverage 6.49% 17.54% +11.05%
======================================================
Files 263 239 -24
Lines 30760 28943 -1817
Branches 30760 28943 -1817
======================================================
+ Hits 1997 5078 +3081
+ Misses 28675 23521 -5154
- Partials 88 344 +256 ☔ View full report in Codecov by Sentry. |
This was referenced Nov 13, 2024
nadin-Starkware
force-pushed
the
spr/main/692fa745
branch
from
241a04d to
adb5187
Compare
nadin-Starkware
force-pushed
the
spr/main/2ca0a7a3
branch
from
d633d48 to
c1ffc3d
Compare
nadin-Starkware
force-pushed
the
spr/main/692fa745
branch
from
adb5187 to
fdf0374
Compare
nadin-Starkware
force-pushed
the
spr/main/2ca0a7a3
branch
from
c1ffc3d to
8361c97
Compare
This was referenced Nov 14, 2024
nadin-Starkware
force-pushed
the
spr/main/692fa745
branch
2 times, most recently
from
ce89cc7 to
fd8aba0
Compare
Itay-Tsabary-Starkware
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @nadin-Starkware)
nadin-Starkware
force-pushed
the
spr/main/692fa745
branch
from
fd8aba0 to
842c944
Compare
commit-id:692fa745
nadin-Starkware
force-pushed
the
spr/main/2ca0a7a3
branch
from
0b2d41a to
056a6e0
Compare
nadin-Starkware
force-pushed
the
spr/main/692fa745
branch
from
842c944 to
1494c27
Compare
nadin-Starkware
commented
Nov 17, 2024
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:
|
✓ Commit merged in pull request #2041 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack: