-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add remote servers struct #2040
Conversation
3173bfe
to
74a56aa
Compare
fcc1c8d
to
24006dd
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## spr/main/d27ad891 #2040 +/- ##
=================================================
Coverage 5.93% 5.93%
=================================================
Files 263 263
Lines 30586 30586
Branches 30586 30586
=================================================
Hits 1816 1816
Misses 28696 28696
Partials 74 74 ☔ View full report in Codecov by Sentry. |
24006dd
to
5a40b5f
Compare
74a56aa
to
17af05d
Compare
5a40b5f
to
9767c7b
Compare
17af05d
to
e090301
Compare
c16cad5
to
b4f55c8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @nadin-Starkware)
crates/starknet_sequencer_node/src/servers.rs
line 47 at r1 (raw file):
// Component servers that can run remotely. pub struct RemoteServers { pub batcher: Option<Box<RemoteBatcherServer>>,
Will pub(crate)
work?
Code quote:
pub
b4f55c8
to
bcd2e46
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @Itay-Tsabary-Starkware)
crates/starknet_sequencer_node/src/servers.rs
line 47 at r1 (raw file):
Previously, Itay-Tsabary-Starkware wrote…
Will
pub(crate)
work?
Yes, I’ll replace it in a later PR—dropping it now would cause a compilation error due to unused code. Adding TODO.
commit-id:ccf812e5
bcd2e46
to
79a9eb6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @nadin-Starkware)
✓ Commit merged in pull request #2041 |
Stack: