Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add remote servers struct #2040

Closed
wants to merge 1 commit into from

Conversation

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 5.93%. Comparing base (4a15085) to head (79a9eb6).

Additional details and impacted files
@@                Coverage Diff                @@
##           spr/main/d27ad891   #2040   +/-   ##
=================================================
  Coverage               5.93%   5.93%           
=================================================
  Files                    263     263           
  Lines                  30586   30586           
  Branches               30586   30586           
=================================================
  Hits                    1816    1816           
  Misses                 28696   28696           
  Partials                  74      74           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @nadin-Starkware)


crates/starknet_sequencer_node/src/servers.rs line 47 at r1 (raw file):

// Component servers that can run remotely.
pub struct RemoteServers {
    pub batcher: Option<Box<RemoteBatcherServer>>,

Will pub(crate) work?

Code quote:

pub 

Copy link
Collaborator Author

@nadin-Starkware nadin-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @Itay-Tsabary-Starkware)


crates/starknet_sequencer_node/src/servers.rs line 47 at r1 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

Will pub(crate) work?

Yes, I’ll replace it in a later PR—dropping it now would cause a compilation error due to unused code. Adding TODO.

Copy link
Contributor

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @nadin-Starkware)

@nadin-Starkware
Copy link
Collaborator Author

✓ Commit merged in pull request #2041

@github-actions github-actions bot locked and limited conversation to collaborators Nov 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants