test: add p2p transaction sync happy flow test

[noamsp-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[noamsp-starkware]

• test: add p2p transaction sync happy flow test #2154 👈 (View in Graphite)
• refactor: add wait_for_marker to p2p_sync:client test_utils #2147 : 1 other dependent PR (#1942 )
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

Artifacts upload triggered. View details here

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.66%. Comparing base (e3165c4) to head (4731dbd).
Report is 593 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #2154       +/-   ##
===========================================
- Coverage   40.10%   23.66%   -16.44%     
===========================================
  Files          26      105       +79     
  Lines        1895    12642    +10747     
  Branches     1895    12642    +10747     
===========================================
+ Hits          760     2992     +2232     
- Misses       1100     9098     +7998     
- Partials       35      552      +517     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ShahakShama]

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @noamsp-starkware)

---

crates/papyrus_test_utils/src/lib.rs line 1130 at r1 (raw file):

}

// TODO: Match memeber types for ExecutionResources and protobuf::receipt::ExecutionResources.

Match makes people think of rust's match. Rephrase to "fix mismatch of ..."

---

crates/papyrus_test_utils/src/lib.rs line 1130 at r1 (raw file):

}

// TODO: Match memeber types for ExecutionResources and protobuf::receipt::ExecutionResources.

for -> between

---

crates/papyrus_p2p_sync/src/client/transaction_test.rs line 90 at r1 (raw file):

        .await;

        // Simulate time has passed so that state diff sync will resend query after it waited for

Change the comment to match transactions

---

crates/papyrus_p2p_sync/src/client/transaction_test.rs line 97 at r1 (raw file):

        let num_transaction_queries = HEADER_QUERY_LENGTH.div_ceil(TRANSACTION_QUERY_LENGTH);
        for transaction_querie in 0..num_transaction_queries {

Change this index name into start_block_number and add a step to the iteration

[noamsp-starkware]

Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @ShahakShama)

---

crates/papyrus_p2p_sync/src/client/transaction_test.rs line 90 at r1 (raw file):

Previously, ShahakShama wrote…

Change the comment to match transactions

Ack

---

crates/papyrus_p2p_sync/src/client/transaction_test.rs line 97 at r1 (raw file):

Previously, ShahakShama wrote…

Change this index name into start_block_number and add a step to the iteration

What do you mean by adding a step to the iteration?

---

crates/papyrus_test_utils/src/lib.rs line 1130 at r1 (raw file):

Previously, ShahakShama wrote…

Match makes people think of rust's match. Rephrase to "fix mismatch of ..."

Ack

---

crates/papyrus_test_utils/src/lib.rs line 1130 at r1 (raw file):

Previously, ShahakShama wrote…

for -> between

Ack

[ShahakShama]

Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @noamsp-starkware)

---

crates/papyrus_p2p_sync/src/client/transaction_test.rs line 97 at r1 (raw file):

Previously, noamsp-starkware wrote…

What do you mean by adding a step to the iteration?

https://stackoverflow.com/questions/27893223/how-do-i-iterate-over-a-range-with-a-custom-step

[noamsp-starkware]

Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @ShahakShama)

---

crates/papyrus_p2p_sync/src/client/transaction_test.rs line 97 at r1 (raw file):

Previously, ShahakShama wrote…

https://stackoverflow.com/questions/27893223/how-do-i-iterate-over-a-range-with-a-custom-step

Ack

[ShahakShama]

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @noamsp-starkware)