test(batcher): block builder transaction failed test

[Yael-Starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[Yael-Starkware]

• test(batcher): block builder transaction failed test #2171 👈 (View in Graphite)
• test(batcher): refactor block builder test #2191
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 5.30%. Comparing base (e3165c4) to head (8aa18b8).
Report is 531 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #2171       +/-   ##
==========================================
- Coverage   40.10%   5.30%   -34.81%     
==========================================
  Files          26     145      +119     
  Lines        1895   16985    +15090     
  Branches     1895   16985    +15090     
==========================================
+ Hits          760     901      +141     
- Misses       1100   16007    +14907     
- Partials       35      77       +42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

---

🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests
• JS Bundle Analysis - Avoid shipping oversized bundles

[Yael-Starkware]

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @alonh5)

---

crates/starknet_batcher/src/block_builder_test.rs line 207 at r1 (raw file):

}

fn transaction_failed_test_expectations(

I can add this test as a case to the previous test, with a bit of refactor.
wdyt?

[Yael-Starkware]

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @alonh5)

---

crates/starknet_batcher/src/block_builder_test.rs line 207 at r1 (raw file):

Previously, Yael-Starkware (YaelD) wrote…

I can add this test as a case to the previous test, with a bit of refactor.
wdyt?

(this comment was supposed to be written over the test function and not here ).

[alonh5]

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Yael-Starkware)

---

crates/starknet_batcher/src/block_builder_test.rs line 207 at r1 (raw file):

Previously, Yael-Starkware (YaelD) wrote…

(this comment was supposed to be written over the test function and not here ).

If it's not to big of a refactor and you think it makes sense, then yeah.

[Yael-Starkware]

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @alonh5)

---

crates/starknet_batcher/src/block_builder_test.rs line 207 at r1 (raw file):

Previously, alonh5 (Alon Haramati) wrote…

If it's not to big of a refactor and you think it makes sense, then yeah.

ack

[alonh5]

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Yael-Starkware)

[Yael-Starkware]

Merge activity

• Nov 20, 9:59 AM EST: A user started a stack merge that includes this pull request via Graphite.
• Nov 20, 10:02 AM EST: Graphite rebased this pull request as part of a merge.
• Nov 20, 10:05 AM EST: Graphite couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'merge-gatekeeper', 'code_style').