Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(batcher): refactor block builder test #2191

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

Yael-Starkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor Author

Yael-Starkware commented Nov 20, 2024

@Yael-Starkware Yael-Starkware marked this pull request as ready for review November 20, 2024 06:36
Copy link
Contributor Author

@Yael-Starkware Yael-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this refactor allows me to add a case of transaction_failed
and also looks nice

Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @alonh5 and @yair-starkware)

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 5.26%. Comparing base (e3165c4) to head (495aefc).
Report is 520 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #2191       +/-   ##
==========================================
- Coverage   40.10%   5.26%   -34.85%     
==========================================
  Files          26     145      +119     
  Lines        1895   17070    +15175     
  Branches     1895   17070    +15175     
==========================================
+ Hits          760     898      +138     
- Misses       1100   16096    +14996     
- Partials       35      76       +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Collaborator

@alonh5 alonh5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR!
:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @yair-starkware)

Copy link
Contributor Author

@Yael-Starkware Yael-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @yair-starkware)

Copy link
Contributor Author

Yael-Starkware commented Nov 20, 2024

Merge activity

  • Nov 20, 9:59 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Nov 20, 9:59 AM EST: A user merged this pull request with Graphite.

@Yael-Starkware Yael-Starkware merged commit 7f452a2 into main Nov 20, 2024
10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants