test(starknet_gateway): handle todo in test_get_block_info #2267

ArniStarkware · 2024-11-25T10:11:19Z

No description provided.

reviewable-StarkWare · 2024-11-25T10:11:26Z

This change is

ArniStarkware · 2024-11-25T10:11:34Z

This stack of pull requests is managed by Graphite. Learn more about stacking.

codecov · 2024-11-25T10:20:46Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.50%. Comparing base (e3165c4) to head (3c716c3).
Report is 704 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #2267       +/-   ##
===========================================
- Coverage   40.10%   26.50%   -13.61%     
===========================================
  Files          26      128      +102     
  Lines        1895    14877    +12982     
  Branches     1895    14877    +12982     
===========================================
+ Hits          760     3943     +3183     
- Misses       1100    10682     +9582     
- Partials       35      252      +217

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

yair-starkware

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Yael-Starkware)

ArniStarkware

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @Yael-Starkware and @yair-starkware)

crates/starknet_gateway/src/rpc_state_reader_test.rs line 74 at r2 (raw file):

Previously, yair-starkware (Yair) wrote…

So the default BlockInfo doesn't match the default L1DataAvailabilityMode?
Is this going to be resolved by removing the default implementation of BlockInfo?

Now they are aligned.
I just modified #2345.

Also - yes - BlockInfo should not have a default value.

yair-starkware

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Yael-Starkware)

ArniStarkware · 2024-12-05T09:36:35Z

Merge activity

Dec 5, 4:36 AM EST: A user started a stack merge that includes this pull request via Graphite.
Dec 5, 4:39 AM EST: Graphite rebased this pull request as part of a merge.
Dec 5, 4:49 AM EST: Graphite couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'merge-gatekeeper', 'codecov').

* chore(starknet_batcher): delete obsolete todo (starkware-libs#2389) * chore(blockifier): add global max_sierra_gas to versioned constants (starkware-libs#2330) * feat(starknet_api): checked mul for gas vector (starkware-libs#2300) * feat(consensus): proposer rotates across validators (starkware-libs#2405) * feat(sequencing): validate streamed proposals (starkware-libs#2305) * feat(ci): deny rust warnings in all workflows (starkware-libs#2388) Signed-off-by: Dori Medini <dori@starkware.co> * feat(blockifier): compute allocation cost (starkware-libs#2301) * chore(starknet_sequencer_infra): add dynamic logging util fn commit-id:9ffe9fbe * chore(starknet_sequencer_infra): add tracing test commit-id:76d16e9a * chore(starknet_sequencer_infra): add run_until utility fn commit-id:194a4b6c * chore(infra_utils): change run_until to support async functions commit-id:92e1f8a3 * chore(starknet_integration_tests): use run_until to await for block creation commit-id:667e001c * chore(infra_utils): rename logger struct commit-id:6520ae54 * chore(blockifier): explicit creation of AccountTransaction (starkware-libs#2331) * test(starknet_integration_tests): test commit blocks by running multiple heights * chore(starknet_batcher): set temp gas prices in propose block input (starkware-libs#2341) * chore(starknet_batcher): set use_kzg_da flag in build block input (starkware-libs#2345) * feat(ci): inherit the rust toolchain toml in moonrepo action (starkware-libs#2423) Signed-off-by: Dori Medini <dori@starkware.co> * chore(blockifier): enforce_fee() impl by api::executable_transaction::AccountTransaction (starkware-libs#2377) * chore(starknet_integration_tests): inherit sequencer node's stdout (starkware-libs#2427) * chore(blockifier): invoke() declare() deploy_account() change ret val to api_tx (starkware-libs#2412) * chore(starknet_consensus_manager): set proposer address in propose block input (starkware-libs#2346) * feat(consensus): add observer mode * feat(consensus): sequencer context broadcasts votes (starkware-libs#2422) * chore(deployment): support unified deployment config (starkware-libs#2378) * feat(starknet_api): add sierra version to class info (starkware-libs#2313) * refactor(starknet_api): change default sierra contract class to valid one (starkware-libs#2439) * feat(starknet_l1_provider): add uninitiailized state and make it the default (starkware-libs#2434) This is to comply with upcoming integration with infra, which separates instantiation with initialization. In particular, `Pending` state should be already post-syncing with L1, whereas `Uninitialized` is unsynced and unusable. Co-Authored-By: Gilad Chase <gilad@starkware.com> * feat(papyrus_storage)!: bump storage version for version 13.4 (starkware-libs#2333) * feat(native_blockifier): allow deserialization of python l1_data_gas (starkware-libs#2447) * refactor(blockifier): split FC to groups base on their tags (starkware-libs#2236) * test(consensus): remove warning on into mock propsal part (starkware-libs#2448) * chore(blockifier): use test_utils::invoke_tx() instead of trans::test_utils::account_invoke_tx() (starkware-libs#2428) * chore(blockifier): save sierra to Feature contracts (starkware-libs#2370) * feat(blockifier): don't count Sierra gas in CairoSteps mode (starkware-libs#2440) * chore(blockifier): convert Sierra gas to L1 gas if in L1 gas mode (starkware-libs#2451) * feat(blockifier): add comprehensive state diff versioned constant (starkware-libs#2407) * chore(starknet_consensus_manager): add chain_id to config * refactor(papyrus_p2p_sync): add random_header utility function (starkware-libs#2381) * chore(starknet_batcher): pass block info from consensus to batcher (starkware-libs#2238) * test(starknet_mempool): tx added to mempool are forwarded to propagator client (starkware-libs#2288) * fix: fix CR comments * test(starknet_mempool): tx added to mempool are forwarded to propagator client * feat(sequencing): cache proposals from bigger heights(starkware-libs#2325) * fix: change to latest ubuntu version in feature combo CI (starkware-libs#2414) * chore(blockifier): replace entry_point_gas_cost with initial_budget (starkware-libs#2247) * test(starknet_gateway): handle todo in test_get_block_info (starkware-libs#2267) * chore(starknet_api): revert use get_packaget_dir instead of env var This reverts commit c45f5cc. commit-id:a48736e7 * chore(starknet_api): rely on env::current_dir() instead of CARGO_MANIFEST_DIR commit-id:301ed4eb * chore(blockifier): move env var from run time to compile time commit-id:80a7265d * chore(starknet_sierra_compile): move env var from run time to compile time commit-id:6e7f2a75 * chore: remove the use of zero as a validator id (starkware-libs#2411) * refactor(papyrus_p2p_sync): add_test receives query size instead of constant (starkware-libs#2379) * fix(blockifier): merge state diff with squash (starkware-libs#2310) * feat(blockifier): get revert receipt only in case of revert (starkware-libs#2471) * chore(starknet_integration_tests): create chain info once (starkware-libs#2482) * chore(starknet_sierra_compile): split build utils commit-id:0f504fd7 * chore(starknet_sierra_compile): set runtime-accessible out_dir env var commit-id:539f16db * chore(starknet_sierra_compile): avoid using OUT_DIR in run time commit-id:cd6fba29 * refactor(starknet_api): use const in sierra version (starkware-libs#2477) * chore: cleanups of OUT_DIR env var (starkware-libs#2484) commit-id:18d61b1d * chore(starknet_api): shorten executable_transaction usage path * fix(sequencing): remove old proposal pipes from consensus (starkware-libs#2452) * test(starknet_integration_tests): match sequencer address with default validator id (starkware-libs#2486) * fix(ci): move specific versioned deps to root toml (starkware-libs#2487) * fix(ci): move specific versioned deps to root toml Signed-off-by: Dori Medini <dori@starkware.co> * fix(starknet_sierra_compile): fix build.rs Signed-off-by: Dori Medini <dori@starkware.co> * chore(starknet_batcher): in block builder use the consensus suplied sequncer address (starkware-libs#2409) * chore: cleanups of CARGO_MANIFEST_DIR env var commit-id:c96f2d88 * fix(starknet_sierra_compile): missing import in feature (starkware-libs#2495) commit-id:abd0a286 * chore(blockifier): add keccak_builtin_gas_cost (starkware-libs#2327) * chore(blockifier): add struct ExecutionFlags to AccTx & use instead of transaction::ExecutionFlags (starkware-libs#2429) * chore(blockifier): add new constructor to AccountTransaction (starkware-libs#2431) * chore(blockifier): remove only_qury from IvokeTxArgs (starkware-libs#2437) * chore(blockifier): remove struct ExecutionFlags and replace w concurrency_mode bool (starkware-libs#2470) * chore(blockifier): remove declare.rs deploy_account.rs invoke.rs from blockifier (starkware-libs#2478) --------- Signed-off-by: Dori Medini <dori@starkware.co> Co-authored-by: YaelD <70628564+Yael-Starkware@users.noreply.github.com> Co-authored-by: aner-starkware <147302140+aner-starkware@users.noreply.github.com> Co-authored-by: yoavGrs <97383386+yoavGrs@users.noreply.github.com> Co-authored-by: matan-starkware <97523054+matan-starkware@users.noreply.github.com> Co-authored-by: guy-starkware <guy.n@starkware.co> Co-authored-by: dorimedini-starkware <dori@starkware.co> Co-authored-by: Itay Tsabary <itayt@starkware.co> Co-authored-by: avivg-starkware <aviv.g@starkware.co> Co-authored-by: Yair Bakalchuk <yair@starkware.co> Co-authored-by: Arnon Hod <arnon@starkware.co> Co-authored-by: Alon Haramati <91828241+alonh5@users.noreply.github.com> Co-authored-by: Asmaa Magdoub <asmaa@starkware.co> Co-authored-by: alon-dotan-starkware <alon.dotan@starkware.co> Co-authored-by: AvivYossef-starkware <141143145+AvivYossef-starkware@users.noreply.github.com> Co-authored-by: giladchase <gilad@starkware.co> Co-authored-by: Gilad Chase <gilad@starkware.com> Co-authored-by: DvirYo-starkware <115620476+DvirYo-starkware@users.noreply.github.com> Co-authored-by: nimrod-starkware <143319383+nimrod-starkware@users.noreply.github.com> Co-authored-by: Meshi Peled <141231558+meship-starkware@users.noreply.github.com> Co-authored-by: Yoni <78365039+Yoni-Starkware@users.noreply.github.com> Co-authored-by: Yael Doweck <yael@starkware.co> Co-authored-by: ShahakShama <70578257+ShahakShama@users.noreply.github.com> Co-authored-by: Alon-Lukatch-Starkware <alon.l@starkware.co> Co-authored-by: Yonatan-Starkware <yonatan.k@starkware.co> Co-authored-by: Yair <92672946+yair-starkware@users.noreply.github.com> Co-authored-by: Itay-Tsabary-Starkware <106665835+Itay-Tsabary-Starkware@users.noreply.github.com>

ArniStarkware mentioned this pull request Nov 25, 2024

chore(starknet_batcher): add block info to block proposal input #2237

Merged

ArniStarkware mentioned this pull request Nov 25, 2024

chore(starknet_batcher): pass block info from consensus to batcher #2238

Merged

ArniStarkware requested review from Yael-Starkware and yair-starkware November 25, 2024 10:11

ArniStarkware marked this pull request as ready for review November 25, 2024 10:11

ArniStarkware force-pushed the arni/batcher/block_builder_factory/use_thin_block_info_to_create_block_info branch from 34b91f6 to 5ee76d7 Compare November 25, 2024 11:43

ArniStarkware force-pushed the arni/test_get_block_info/handle_todo branch from 75e6fcb to c3fb9d3 Compare November 25, 2024 11:43

ArniStarkware force-pushed the arni/batcher/block_builder_factory/use_thin_block_info_to_create_block_info branch from 5ee76d7 to 3ca06ee Compare November 25, 2024 11:50

ArniStarkware force-pushed the arni/test_get_block_info/handle_todo branch from c3fb9d3 to e0c7fe9 Compare November 25, 2024 11:50

ArniStarkware force-pushed the arni/batcher/block_builder_factory/use_thin_block_info_to_create_block_info branch from 3ca06ee to f42ec91 Compare November 25, 2024 14:44

ArniStarkware force-pushed the arni/test_get_block_info/handle_todo branch from e0c7fe9 to d0c03d3 Compare November 25, 2024 14:45

ArniStarkware force-pushed the arni/batcher/block_builder_factory/use_thin_block_info_to_create_block_info branch from f42ec91 to 8c52c40 Compare November 25, 2024 14:57

ArniStarkware force-pushed the arni/test_get_block_info/handle_todo branch from d0c03d3 to edbc8cd Compare November 25, 2024 14:57

yair-starkware approved these changes Nov 26, 2024

View reviewed changes

ArniStarkware force-pushed the arni/batcher/block_builder_factory/use_thin_block_info_to_create_block_info branch from 8c52c40 to 7b711ef Compare November 26, 2024 13:24

ArniStarkware force-pushed the arni/test_get_block_info/handle_todo branch from edbc8cd to d8423b9 Compare November 26, 2024 13:24

ArniStarkware force-pushed the arni/batcher/block_builder_factory/use_thin_block_info_to_create_block_info branch from 7b711ef to c9b45db Compare November 26, 2024 15:24

ArniStarkware force-pushed the arni/test_get_block_info/handle_todo branch from d8423b9 to 6774b77 Compare November 26, 2024 15:25

ArniStarkware force-pushed the arni/batcher/block_builder_factory/use_thin_block_info_to_create_block_info branch from c9b45db to f0bb379 Compare November 27, 2024 09:32

ArniStarkware force-pushed the arni/test_get_block_info/handle_todo branch from 6774b77 to 7d68afd Compare November 27, 2024 09:32

ArniStarkware mentioned this pull request Nov 27, 2024

test(batcher): set const block info for batcher test #2302

Closed

ArniStarkware force-pushed the arni/batcher/block_builder_factory/use_thin_block_info_to_create_block_info branch from f0bb379 to ec9a40a Compare November 28, 2024 07:06

ArniStarkware force-pushed the arni/test_get_block_info/handle_todo branch from 7d68afd to 4e47bbb Compare November 28, 2024 07:06

ArniStarkware force-pushed the arni/batcher/block_builder_factory/use_thin_block_info_to_create_block_info branch from ec9a40a to 76198f7 Compare November 28, 2024 07:56

ArniStarkware force-pushed the arni/test_get_block_info/handle_todo branch from 4e47bbb to 93b0d3d Compare November 28, 2024 07:56

ArniStarkware force-pushed the arni/batcher/block_builder_factory/use_thin_block_info_to_create_block_info branch from 76198f7 to 96becc4 Compare November 28, 2024 09:18

ArniStarkware force-pushed the arni/test_get_block_info/handle_todo branch from 93b0d3d to 05b6301 Compare November 28, 2024 09:19

ArniStarkware force-pushed the arni/test_get_block_info/handle_todo branch from ea0f7c8 to c2be422 Compare December 1, 2024 13:52

ArniStarkware commented Dec 1, 2024

View reviewed changes

yair-starkware approved these changes Dec 2, 2024

View reviewed changes

ArniStarkware force-pushed the arni/batcher/block_builder_factory/use_thin_block_info_to_create_block_info branch 2 times, most recently from ddb60ec to c47ff9a Compare December 2, 2024 15:06

ArniStarkware force-pushed the arni/test_get_block_info/handle_todo branch from c2be422 to 108a5e9 Compare December 2, 2024 15:07

ArniStarkware mentioned this pull request Dec 2, 2024

chore(starknet_batcher): in block builder use the consensus suplied sequncer address #2409

Merged

ArniStarkware force-pushed the arni/batcher/block_builder_factory/use_thin_block_info_to_create_block_info branch from c47ff9a to 522d4cc Compare December 2, 2024 15:27

ArniStarkware changed the title ~~test(gateway): handle todo in test_get_block_info~~ test(starknet_gateway): handle todo in test_get_block_info Dec 3, 2024

ArniStarkware force-pushed the arni/batcher/block_builder_factory/use_thin_block_info_to_create_block_info branch from 522d4cc to 521b91e Compare December 3, 2024 10:59

ArniStarkware mentioned this pull request Dec 3, 2024

chore(starknet_batcher): remove sequncer address from block builder config #2425

Closed

ArniStarkware force-pushed the arni/batcher/block_builder_factory/use_thin_block_info_to_create_block_info branch from 521b91e to 87dd372 Compare December 3, 2024 12:53

ArniStarkware force-pushed the arni/test_get_block_info/handle_todo branch from 108a5e9 to c1b7e8a Compare December 3, 2024 12:54

ArniStarkware force-pushed the arni/batcher/block_builder_factory/use_thin_block_info_to_create_block_info branch from 87dd372 to f8df7da Compare December 3, 2024 14:15

ArniStarkware force-pushed the arni/test_get_block_info/handle_todo branch from c1b7e8a to 36fc389 Compare December 3, 2024 14:15

ArniStarkware force-pushed the arni/batcher/block_builder_factory/use_thin_block_info_to_create_block_info branch 2 times, most recently from 30ae007 to 50bb19b Compare December 3, 2024 14:47

ArniStarkware force-pushed the arni/test_get_block_info/handle_todo branch from 36fc389 to d5b01e7 Compare December 3, 2024 14:47

ArniStarkware force-pushed the arni/batcher/block_builder_factory/use_thin_block_info_to_create_block_info branch from 50bb19b to 616d561 Compare December 3, 2024 16:06

ArniStarkware force-pushed the arni/test_get_block_info/handle_todo branch from d5b01e7 to 54a7078 Compare December 3, 2024 16:06

ArniStarkware changed the base branch from arni/batcher/block_builder_factory/use_thin_block_info_to_create_block_info to graphite-base/2267 December 5, 2024 09:36

ArniStarkware changed the base branch from graphite-base/2267 to main December 5, 2024 09:37

ArniStarkware force-pushed the arni/test_get_block_info/handle_todo branch from 54a7078 to 9c6219a Compare December 5, 2024 09:38

test(starknet_gateway): handle todo in test_get_block_info

3c716c3

ArniStarkware force-pushed the arni/test_get_block_info/handle_todo branch from 9c6219a to 3c716c3 Compare December 5, 2024 10:47

ArniStarkware merged commit 9c783f5 into main Dec 5, 2024
10 checks passed

github-actions bot locked and limited conversation to collaborators Dec 7, 2024

ArniStarkware deleted the arni/test_get_block_info/handle_todo branch December 16, 2024 13:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test(starknet_gateway): handle todo in test_get_block_info #2267

test(starknet_gateway): handle todo in test_get_block_info #2267

ArniStarkware commented Nov 25, 2024

reviewable-StarkWare commented Nov 25, 2024

ArniStarkware commented Nov 25, 2024 •

edited

Loading

codecov bot commented Nov 25, 2024 •

edited

Loading

yair-starkware left a comment

ArniStarkware left a comment

yair-starkware left a comment

ArniStarkware commented Dec 5, 2024 •

edited

Loading

test(starknet_gateway): handle todo in test_get_block_info #2267

test(starknet_gateway): handle todo in test_get_block_info #2267

Conversation

ArniStarkware commented Nov 25, 2024

reviewable-StarkWare commented Nov 25, 2024

ArniStarkware commented Nov 25, 2024 • edited Loading

codecov bot commented Nov 25, 2024 • edited Loading

Codecov Report

yair-starkware left a comment

Choose a reason for hiding this comment

ArniStarkware left a comment

Choose a reason for hiding this comment

yair-starkware left a comment

Choose a reason for hiding this comment

ArniStarkware commented Dec 5, 2024 • edited Loading

Merge activity

ArniStarkware commented Nov 25, 2024 •

edited

Loading

codecov bot commented Nov 25, 2024 •

edited

Loading

ArniStarkware commented Dec 5, 2024 •

edited

Loading