Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(batcher): set const block info for batcher test #2302

Closed
wants to merge 1 commit into from
Closed

test(batcher): set const block info for batcher test #2302

wants to merge 1 commit into from

Conversation

ArniStarkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

This was referenced Nov 27, 2024
Merged
Merged
@ArniStarkware Graphite App
Copy link
Contributor Author

ArniStarkware commented Nov 27, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ArniStarkware ArniStarkware mentioned this pull request Nov 27, 2024
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 27, 2024 •
edited
Loading

Artifacts upload workflows:

@codecov Codecov
Copy link

codecov bot commented Nov 27, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 85.71429% with 3 lines in your changes missing coverage. Please review.

Project coverage is 63.22%. Comparing base (616d561) to head (548bb28).

Files with missing lines Patch % Lines
crates/starknet_api/src/core.rs 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@                   Coverage Diff                   @@
##           graphite-base/2302    #2302       +/-   ##
=======================================================
+ Coverage               13.20%   63.22%   +50.02%     
=======================================================
  Files                     144      159       +15     
  Lines                   17078    18215     +1137     
  Branches                17078    18215     +1137     
=======================================================
+ Hits                     2255    11517     +9262     
+ Misses                  14707     6201     -8506     
- Partials                  116      497      +381

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArniStarkware ArniStarkware force-pushed the arni/batcher/block_builder_factory/use_thin_block_info_to_create_block_info branch from f0bb379 to ec9a40a Compare November 28, 2024 07:06
@ArniStarkware ArniStarkware force-pushed the arni/batcher/block_builder_factory/test_const_block_info branch from 8fcde92 to 8fa4857 Compare November 28, 2024 07:06
@ArniStarkware ArniStarkware force-pushed the arni/batcher/block_builder_factory/use_thin_block_info_to_create_block_info branch from ec9a40a to 76198f7 Compare November 28, 2024 07:56
@ArniStarkware ArniStarkware force-pushed the arni/batcher/block_builder_factory/test_const_block_info branch from 8fa4857 to 200f51e Compare November 28, 2024 07:57
@github-actions GitHub Actions
Copy link

Benchmark movements:
tree_computation_flow performance regressed!
tree_computation_flow time: [34.860 ms 35.386 ms 36.003 ms]
change: [+1.4680% +2.9306% +5.0111%] (p = 0.00 < 0.05)
Performance has regressed.
Found 9 outliers among 100 measurements (9.00%)
1 (1.00%) high mild
8 (8.00%) high severe

@ArniStarkware ArniStarkware force-pushed the arni/batcher/block_builder_factory/use_thin_block_info_to_create_block_info branch from 76198f7 to 96becc4 Compare November 28, 2024 09:18
@ArniStarkware ArniStarkware force-pushed the arni/batcher/block_builder_factory/test_const_block_info branch from 200f51e to c356177 Compare November 28, 2024 09:20
@ArniStarkware ArniStarkware force-pushed the arni/batcher/block_builder_factory/use_thin_block_info_to_create_block_info branch from 96becc4 to d6f8b92 Compare November 28, 2024 09:42
@ArniStarkware ArniStarkware force-pushed the arni/batcher/block_builder_factory/test_const_block_info branch from c356177 to d8d08ed Compare November 28, 2024 09:43
@ArniStarkware ArniStarkware force-pushed the arni/batcher/block_builder_factory/use_thin_block_info_to_create_block_info branch from d6f8b92 to cefe8d0 Compare November 28, 2024 09:58
@ArniStarkware ArniStarkware force-pushed the arni/batcher/block_builder_factory/test_const_block_info branch from d8d08ed to e5fd543 Compare November 28, 2024 09:59
@ArniStarkware ArniStarkware force-pushed the arni/batcher/block_builder_factory/use_thin_block_info_to_create_block_info branch from cefe8d0 to d748880 Compare November 28, 2024 10:19
@ArniStarkware ArniStarkware force-pushed the arni/batcher/block_builder_factory/test_const_block_info branch from e5fd543 to 4281276 Compare November 28, 2024 10:20
@github-actions GitHub Actions
Copy link

Benchmark movements:
tree_computation_flow performance regressed!
tree_computation_flow time: [34.774 ms 35.356 ms 36.039 ms]
change: [+1.5639% +3.3155% +5.1966%] (p = 0.00 < 0.05)
Performance has regressed.
Found 14 outliers among 100 measurements (14.00%)
1 (1.00%) high mild
13 (13.00%) high severe

@ArniStarkware ArniStarkware force-pushed the arni/batcher/block_builder_factory/use_thin_block_info_to_create_block_info branch from d748880 to fdac316 Compare November 28, 2024 10:44
@ArniStarkware ArniStarkware force-pushed the arni/batcher/block_builder_factory/test_const_block_info branch from 4281276 to 6779152 Compare November 28, 2024 10:45
@ArniStarkware ArniStarkware force-pushed the arni/batcher/block_builder_factory/use_thin_block_info_to_create_block_info branch from fdac316 to f6e1da2 Compare November 28, 2024 12:50
@ArniStarkware ArniStarkware force-pushed the arni/batcher/block_builder_factory/test_const_block_info branch from 6779152 to 782cec3 Compare November 28, 2024 12:50
This was referenced Nov 28, 2024
Merged
Merged
Merged
Merged
@ArniStarkware ArniStarkware force-pushed the arni/batcher/block_builder_factory/use_thin_block_info_to_create_block_info branch from f6e1da2 to 413c3d2 Compare November 28, 2024 13:58
@ArniStarkware ArniStarkware force-pushed the arni/batcher/block_builder_factory/test_const_block_info branch from 782cec3 to dd94899 Compare November 28, 2024 13:58
@github-actions GitHub Actions
Copy link

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [40.789 ms 41.394 ms 42.028 ms]
change: [-9.8240% -7.4286% -5.0208%] (p = 0.00 < 0.05)
Performance has improved.
Found 6 outliers among 100 measurements (6.00%)
6 (6.00%) high mild

@ArniStarkware ArniStarkware force-pushed the arni/batcher/block_builder_factory/use_thin_block_info_to_create_block_info branch from 413c3d2 to b0aff4d Compare November 28, 2024 15:35
This was referenced Nov 28, 2024
Merged
Merged
@ArniStarkware ArniStarkware force-pushed the arni/batcher/block_builder_factory/use_thin_block_info_to_create_block_info branch 4 times, most recently from ddb60ec to c47ff9a Compare December 2, 2024 15:06
@ArniStarkware ArniStarkware mentioned this pull request Dec 2, 2024
Merged
@ArniStarkware ArniStarkware force-pushed the arni/batcher/block_builder_factory/use_thin_block_info_to_create_block_info branch 2 times, most recently from 522d4cc to 521b91e Compare December 3, 2024 10:59
@ArniStarkware ArniStarkware mentioned this pull request Dec 3, 2024
Closed
@ArniStarkware ArniStarkware force-pushed the arni/batcher/block_builder_factory/use_thin_block_info_to_create_block_info branch 2 times, most recently from 87dd372 to f8df7da Compare December 3, 2024 14:15
@ArniStarkware ArniStarkware force-pushed the arni/batcher/block_builder_factory/test_const_block_info branch from dd94899 to 32d30dd Compare December 3, 2024 14:15
@ArniStarkware ArniStarkware force-pushed the arni/batcher/block_builder_factory/use_thin_block_info_to_create_block_info branch 2 times, most recently from 30ae007 to 50bb19b Compare December 3, 2024 14:47
@ArniStarkware ArniStarkware force-pushed the arni/batcher/block_builder_factory/test_const_block_info branch from 32d30dd to c9175bf Compare December 3, 2024 14:48
@ArniStarkware ArniStarkware force-pushed the arni/batcher/block_builder_factory/use_thin_block_info_to_create_block_info branch from 50bb19b to 616d561 Compare December 3, 2024 16:06
@ArniStarkware ArniStarkware force-pushed the arni/batcher/block_builder_factory/test_const_block_info branch from c9175bf to 548bb28 Compare December 3, 2024 16:07
@ArniStarkware ArniStarkware changed the base branch from arni/batcher/block_builder_factory/use_thin_block_info_to_create_block_info to graphite-base/2302 December 5, 2024 09:36
@ArniStarkware
Copy link
Contributor Author

Replaced with Split PRs.

@ArniStarkware ArniStarkware deleted the arni/batcher/block_builder_factory/test_const_block_info branch December 9, 2024 15:32
@github-actions github-actions bot locked and limited conversation to collaborators Dec 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ArniStarkware @reviewable-StarkWare