chore(starknet_batcher): add height as input #2339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
This was referenced Nov 28, 2024
This was referenced Nov 28, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2339 +/- ##
===========================================
- Coverage 40.10% 17.66% -22.44%
===========================================
Files 26 119 +93
Lines 1895 13901 +12006
Branches 1895 13901 +12006
===========================================
+ Hits 760 2456 +1696
- Misses 1100 11174 +10074
- Partials 35 271 +236 ☔ View full report in Codecov by Sentry. |
This was referenced Nov 28, 2024
ArniStarkware
force-pushed
the
arni/batcher/block_builder_factory/proposal_block_input/add_thin_block_info
branch
from
e1a8da8 to
f632fef
Compare
ArniStarkware
force-pushed
the
arni/batcher/block_builder_factory/set_height_as_proposal_input
branch
from
7de50f1 to
3021db8
Compare
alonh5
approved these changes
Dec 1, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ArniStarkware)
a discussion (no related file):
This should be part of the previous PR IMO.
ArniStarkware
force-pushed
the
arni/batcher/block_builder_factory/proposal_block_input/add_thin_block_info
branch
from
f632fef to
9d77f07
Compare
ArniStarkware
force-pushed
the
arni/batcher/block_builder_factory/set_height_as_proposal_input
branch
from
3021db8 to
b8050db
Compare
ArniStarkware
changed the title
ArniStarkware
force-pushed
the
arni/batcher/block_builder_factory/proposal_block_input/add_thin_block_info
branch
from
9d77f07 to
2377c06
Compare
ArniStarkware
force-pushed
the
arni/batcher/block_builder_factory/set_height_as_proposal_input
branch
from
b8050db to
b173393
Compare
ArniStarkware
force-pushed
the
arni/batcher/block_builder_factory/proposal_block_input/add_thin_block_info
branch
from
2377c06 to
51b84b7
Compare
ArniStarkware
changed the base branch from
arni/batcher/block_builder_factory/proposal_block_input/add_thin_block_info
to
graphite-base/2339
ArniStarkware
force-pushed
the
graphite-base/2339
branch
from
51b84b7 to
0bf74a9
Compare
ArniStarkware
force-pushed
the
arni/batcher/block_builder_factory/set_height_as_proposal_input
branch
from
b173393 to
36ecfc6
Compare
ArniStarkware
force-pushed
the
arni/batcher/block_builder_factory/set_height_as_proposal_input
branch
from
36ecfc6 to
b63149a
Compare
ArniStarkware
commented
Dec 2, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ArniStarkware)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.