Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(starknet_batcher): add height as input #2339

Merged
merged 1 commit into from
Dec 2, 2024
Merged

chore(starknet_batcher): add height as input #2339

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions crates/sequencing/papyrus_consensus_orchestrator/src/sequencer_consensus_context.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ use papyrus_protobuf::consensus::{
TransactionBatch,
Vote,
};
use starknet_api::block::{BlockHash, BlockHashAndNumber, BlockNumber};
use starknet_api::block::{BlockHash, BlockHashAndNumber, BlockInfo, BlockNumber};
use starknet_api::executable_transaction::Transaction;
use starknet_batcher_types::batcher_types::{
DecisionReachedInput,
Expand Down Expand Up @@ -140,7 +140,7 @@ impl ConsensusContext for SequencerConsensusContext {
hash: BlockHash::default(),
}),
// TODO(Dan, Matan): Fill block info.
block_info: Default::default(),
block_info: BlockInfo { block_number: proposal_init.height, ..Default::default() },
};
// TODO: Should we be returning an error?
// I think this implies defining an error type in this crate and moving the trait definition
Expand Down Expand Up @@ -323,7 +323,7 @@ impl SequencerConsensusContext {
hash: BlockHash::default(),
}),
// TODO(Dan, Matan): Fill block info.
block_info: Default::default(),
block_info: BlockInfo { block_number: height, ..Default::default() },
};
batcher.validate_block(input).await.expect("Failed to initiate proposal validation");

Expand Down
Loading