Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(starknet_batcher): set temp gas prices in propose block input #2341

Merged

Conversation

ArniStarkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 18.04%. Comparing base (e3165c4) to head (c2e4423).
Report is 675 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2341       +/-   ##
===========================================
- Coverage   40.10%   18.04%   -22.06%     
===========================================
  Files          26      119       +93     
  Lines        1895    14034    +12139     
  Branches     1895    14034    +12139     
===========================================
+ Hits          760     2533     +1773     
- Misses       1100    11231    +10131     
- Partials       35      270      +235     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@alonh5 alonh5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ArniStarkware)

@ArniStarkware ArniStarkware force-pushed the arni/batcher/propose_block/verify/block_number branch from 7fc654e to 14db3f5 Compare December 1, 2024 12:34
@ArniStarkware ArniStarkware force-pushed the arni/batcher/block_builder_factory/set_gas_prices branch from 6158a58 to 37ca509 Compare December 1, 2024 12:39
@ArniStarkware ArniStarkware changed the title chore(batcher): set temp gas prices in propose block input chore(starknet_batcher): set temp gas prices in propose block input Dec 1, 2024
@ArniStarkware ArniStarkware force-pushed the arni/batcher/propose_block/verify/block_number branch from 14db3f5 to 8270819 Compare December 2, 2024 09:23
@ArniStarkware ArniStarkware force-pushed the arni/batcher/block_builder_factory/set_gas_prices branch from 37ca509 to 3564bee Compare December 2, 2024 09:23
@ArniStarkware ArniStarkware force-pushed the arni/batcher/propose_block/verify/block_number branch from 8270819 to 02e7c3d Compare December 2, 2024 13:22
@ArniStarkware ArniStarkware force-pushed the arni/batcher/block_builder_factory/set_gas_prices branch from 3564bee to 5b58ea9 Compare December 2, 2024 13:23
@ArniStarkware ArniStarkware changed the base branch from arni/batcher/propose_block/verify/block_number to graphite-base/2341 December 2, 2024 13:48
@ArniStarkware ArniStarkware force-pushed the arni/batcher/block_builder_factory/set_gas_prices branch from 5b58ea9 to 7b83d10 Compare December 2, 2024 13:59
@ArniStarkware ArniStarkware changed the base branch from graphite-base/2341 to main December 2, 2024 14:00
@ArniStarkware ArniStarkware force-pushed the arni/batcher/block_builder_factory/set_gas_prices branch 2 times, most recently from 71bf431 to b927f8a Compare December 2, 2024 14:33
@ArniStarkware ArniStarkware changed the base branch from main to arni/batcher/block_builder_factory/set_block_timestamp December 2, 2024 14:33
@ArniStarkware ArniStarkware changed the base branch from arni/batcher/block_builder_factory/set_block_timestamp to graphite-base/2341 December 2, 2024 15:04
@ArniStarkware ArniStarkware force-pushed the arni/batcher/block_builder_factory/set_gas_prices branch from b927f8a to 2a4a5b5 Compare December 2, 2024 15:04
@ArniStarkware ArniStarkware changed the base branch from graphite-base/2341 to main December 2, 2024 15:05
@ArniStarkware ArniStarkware force-pushed the arni/batcher/block_builder_factory/set_gas_prices branch from 2a4a5b5 to 6cfb9f4 Compare December 2, 2024 15:05
@ArniStarkware ArniStarkware force-pushed the arni/batcher/block_builder_factory/set_gas_prices branch from 6cfb9f4 to 7426fef Compare December 2, 2024 15:27
Copy link
Contributor

@matan-starkware matan-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ArniStarkware)


crates/sequencing/papyrus_consensus_orchestrator/src/sequencer_consensus_context.rs line 60 at r3 (raw file):

use tracing::{debug, debug_span, error, info, trace, warn, Instrument};

// TODO(Dan, Matan): Remove this once and replace with real gas prices.

Where will this info come from? When do we need to integrate this? Feel free to answer offline.

@dan-starkware @alonh5

Code quote:

// TODO(Dan, Matan): Remove this once and replace with real gas prices.

Copy link
Collaborator

@alonh5 alonh5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dan-starkware)


crates/sequencing/papyrus_consensus_orchestrator/src/sequencer_consensus_context.rs line 60 at r3 (raw file):

Previously, matan-starkware wrote…

Where will this info come from? When do we need to integrate this? Feel free to answer offline.

@dan-starkware @alonh5

The L2 gas prices should be calculated according to 1559, which is in the next milestone at the end of the month.
Part of the calculation should already be implemented.
And the L1 gas prices should be retrieved from L1. Not for the next milestone AFAIK.

Copy link
Contributor Author

ArniStarkware commented Dec 3, 2024

Merge activity

  • Dec 3, 7:31 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Dec 3, 7:32 AM EST: A user merged this pull request with Graphite.

@ArniStarkware ArniStarkware merged commit 4a0c19f into main Dec 3, 2024
16 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants