-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(starknet_batcher): set temp gas prices in propose block input #2341
chore(starknet_batcher): set temp gas prices in propose block input #2341
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2341 +/- ##
===========================================
- Coverage 40.10% 18.04% -22.06%
===========================================
Files 26 119 +93
Lines 1895 14034 +12139
Branches 1895 14034 +12139
===========================================
+ Hits 760 2533 +1773
- Misses 1100 11231 +10131
- Partials 35 270 +235 ☔ View full report in Codecov by Sentry. |
9ad8065
to
7fc654e
Compare
6541e23
to
6158a58
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ArniStarkware)
7fc654e
to
14db3f5
Compare
6158a58
to
37ca509
Compare
14db3f5
to
8270819
Compare
37ca509
to
3564bee
Compare
8270819
to
02e7c3d
Compare
3564bee
to
5b58ea9
Compare
5b58ea9
to
7b83d10
Compare
02e7c3d
to
2daa67d
Compare
71bf431
to
b927f8a
Compare
b927f8a
to
2a4a5b5
Compare
5e5126a
to
26bd6aa
Compare
2a4a5b5
to
6cfb9f4
Compare
6cfb9f4
to
7426fef
Compare
7426fef
to
c2e4423
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ArniStarkware)
crates/sequencing/papyrus_consensus_orchestrator/src/sequencer_consensus_context.rs
line 60 at r3 (raw file):
use tracing::{debug, debug_span, error, info, trace, warn, Instrument}; // TODO(Dan, Matan): Remove this once and replace with real gas prices.
Where will this info come from? When do we need to integrate this? Feel free to answer offline.
Code quote:
// TODO(Dan, Matan): Remove this once and replace with real gas prices.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dan-starkware)
crates/sequencing/papyrus_consensus_orchestrator/src/sequencer_consensus_context.rs
line 60 at r3 (raw file):
Previously, matan-starkware wrote…
Where will this info come from? When do we need to integrate this? Feel free to answer offline.
The L2 gas prices should be calculated according to 1559, which is in the next milestone at the end of the month.
Part of the calculation should already be implemented.
And the L1 gas prices should be retrieved from L1. Not for the next milestone AFAIK.
No description provided.