-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(tests_integration): move http client test util #2314
Conversation
0da3e11
to
695217d
Compare
Benchmark movements: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2314 +/- ##
===========================================
+ Coverage 40.10% 77.47% +37.36%
===========================================
Files 26 386 +360
Lines 1895 40607 +38712
Branches 1895 40607 +38712
===========================================
+ Hits 760 31460 +30700
- Misses 1100 6827 +5727
- Partials 35 2320 +2285 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 9 of 9 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Itay-Tsabary-Starkware)
crates/starknet_http_server/Cargo.toml
line 17 at r1 (raw file):
axum.workspace = true hyper.workspace = true mempool_test_utils = { workspace = true, optional = true }
should it be in [dev-dependencies] ?
crates/starknet_http_server/Cargo.toml
line 19 at r1 (raw file):
mempool_test_utils = { workspace = true, optional = true } papyrus_config.workspace = true reqwest = { workspace = true, optional = true }
As above
695217d
to
4431b53
Compare
Benchmark movements: |
commit-id:2d145538
4431b53
to
0ab06cf
Compare
✓ Commit merged in pull request #2319 |
Stack: