Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tests_integration): move http client test util #2314

Closed
wants to merge 1 commit into from

Conversation

Itay-Tsabary-Starkware
Copy link
Contributor

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware commented Nov 27, 2024

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

Benchmark movements:
tree_computation_flow performance regressed!
tree_computation_flow time: [35.595 ms 35.679 ms 35.781 ms]
change: [+1.2858% +1.5906% +1.9440%] (p = 0.00 < 0.05)
Performance has regressed.
Found 8 outliers among 100 measurements (8.00%)
3 (3.00%) high mild
5 (5.00%) high severe

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.47%. Comparing base (e3165c4) to head (0ab06cf).
Report is 620 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2314       +/-   ##
===========================================
+ Coverage   40.10%   77.47%   +37.36%     
===========================================
  Files          26      386      +360     
  Lines        1895    40607    +38712     
  Branches     1895    40607    +38712     
===========================================
+ Hits          760    31460    +30700     
- Misses       1100     6827     +5727     
- Partials       35     2320     +2285     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@lev-starkware lev-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 9 of 9 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Itay-Tsabary-Starkware)


crates/starknet_http_server/Cargo.toml line 17 at r1 (raw file):

axum.workspace = true
hyper.workspace = true
mempool_test_utils = { workspace = true, optional = true }

should it be in [dev-dependencies] ?


crates/starknet_http_server/Cargo.toml line 19 at r1 (raw file):

mempool_test_utils = { workspace = true, optional = true }
papyrus_config.workspace = true
reqwest = { workspace = true, optional = true }

As above

Copy link

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [34.586 ms 34.639 ms 34.699 ms]
change: [-1.6037% -1.2969% -1.0134%] (p = 0.00 < 0.05)
Performance has improved.
Found 7 outliers among 100 measurements (7.00%)
4 (4.00%) high mild
3 (3.00%) high severe

@Itay-Tsabary-Starkware
Copy link
Contributor Author

✓ Commit merged in pull request #2319

@github-actions github-actions bot locked and limited conversation to collaborators Dec 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants