Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tests_integration): move node runner test util #2319

Merged
merged 2 commits into from
Nov 28, 2024

Conversation

Itay-Tsabary-Starkware
Copy link
Contributor

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware commented Nov 28, 2024

commit-id:2959cc90


Stack:

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

@reviewable-StarkWare
Copy link

This change is Reviewable

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware changed the base branch from spr/main/2d145538 to main November 28, 2024 08:59
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware changed the base branch from main to spr/main/2d145538 November 28, 2024 09:00
Copy link

github-actions bot commented Nov 28, 2024

Artifacts upload workflows:

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 72.41379% with 8 lines in your changes missing coverage. Please review.

Project coverage is 77.55%. Comparing base (e3165c4) to head (9dc416a).
Report is 621 commits behind head on main.

Files with missing lines Patch % Lines
...rknet_sequencer_node/src/test_utils/compilation.rs 72.41% 2 Missing and 6 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2319       +/-   ##
===========================================
+ Coverage   40.10%   77.55%   +37.44%     
===========================================
  Files          26      386      +360     
  Lines        1895    40799    +38904     
  Branches     1895    40799    +38904     
===========================================
+ Hits          760    31641    +30881     
- Misses       1100     6830     +5730     
- Partials       35     2328     +2293     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@lev-starkware lev-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 2 files reviewed, all discussions resolved

Copy link
Contributor

@lev-starkware lev-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware changed the base branch from spr/main/2d145538 to main November 28, 2024 10:40
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware merged commit 1b94f6e into main Nov 28, 2024
22 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants